-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSP: firefox reports are not triggering events #2475
Comments
Do you have a page that reproduces? I'm curious what the payload was that was sent. It's likely that it got filtered out as garbage, but can't say for sure without knowing the payload. :) |
Hard to tell, because Firefox doesn't capture the POST body when you do
|
Ah, yes, because the report is missing the effective-directive entirely. See: http://www.w3.org/TR/CSP/#violation-report-effective-directive Without this value on our side, it makes it much much harder to group effectively, so we discard reports that don't include it since the spec suggests that it should exist. |
We ultimately end up grouping on this: https://github.com/getsentry/sentry/blob/master/src/sentry/interfaces/csp.py#L141 So we attempt to group on something like: I guess in your case though, Unless I've misunderstood, it seems that Do you know if this is correct in FF 43? (I can check if you don't know off hand). |
Apparently there is issue reported on this: https://bugzilla.mozilla.org/show_bug.cgi?id=1192684 . |
Ah. Yeah, this comment sums up my findings as well: https://bugzilla.mozilla.org/show_bug.cgi?id=1192684#c4 @shekyan is there anything else to add to this? Or can we close? I'm going to err on the side that this is Mozilla's job to implement this into Firefox and there's not much we can do here otherwise. |
Let's just pray and hope. |
🙏 |
Firefox 42 generates CSP violation reports that are visible in the diagram on the dashboard, but no events are generated.
The text was updated successfully, but these errors were encountered: