From c8cd66acb6f0854599d8e0a7c093ddde4732ede2 Mon Sep 17 00:00:00 2001 From: Josh Ferge Date: Wed, 6 Oct 2021 09:16:21 -0700 Subject: [PATCH] remove client discards from totals on orgstats projects (#29079) --- .../organizationStats/usageStatsProjects.tsx | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/static/app/views/organizationStats/usageStatsProjects.tsx b/static/app/views/organizationStats/usageStatsProjects.tsx index b04e54ecf5400d..c9fde6a0731709 100644 --- a/static/app/views/organizationStats/usageStatsProjects.tsx +++ b/static/app/views/organizationStats/usageStatsProjects.tsx @@ -13,7 +13,7 @@ import {t} from 'app/locale'; import {DataCategory, Organization, Project} from 'app/types'; import withProjects from 'app/utils/withProjects'; -import {UsageSeries} from './types'; +import {Outcome, UsageSeries} from './types'; import UsageTable, {CellProject, CellStat, TableStat} from './usageTable'; type Props = { @@ -334,15 +334,17 @@ class UsageStatsProjects extends AsyncComponent { stats[projectId] = {...baseStat}; } - stats[projectId].total += group.totals['sum(quantity)']; + if (outcome !== Outcome.CLIENT_DISCARD) { + stats[projectId].total += group.totals['sum(quantity)']; + } - if ( - outcome === SortBy.ACCEPTED || - outcome === SortBy.FILTERED || - outcome === SortBy.DROPPED - ) { + if (outcome === Outcome.ACCEPTED || outcome === Outcome.FILTERED) { stats[projectId][outcome] += group.totals['sum(quantity)']; - } else { + } else if ( + outcome === Outcome.RATE_LIMITED || + outcome === Outcome.INVALID || + outcome === Outcome.DROPPED + ) { stats[projectId][SortBy.DROPPED] += group.totals['sum(quantity)']; } });