diff --git a/static/app/views/alerts/incidentRules/triggers/thresholdControl.tsx b/static/app/views/alerts/incidentRules/triggers/thresholdControl.tsx index 198b52d627f274..290cd8e1d94037 100644 --- a/static/app/views/alerts/incidentRules/triggers/thresholdControl.tsx +++ b/static/app/views/alerts/incidentRules/triggers/thresholdControl.tsx @@ -145,6 +145,7 @@ class ThresholdControl extends React.Component { , - routerContext + {context: routerContext} ); expect(eventStatsMock).toHaveBeenCalledWith( diff --git a/tests/js/spec/views/alerts/incidentRules/details.spec.jsx b/tests/js/spec/views/alerts/incidentRules/details.spec.jsx index d0a96920aaec7b..eff88f3c7e906e 100644 --- a/tests/js/spec/views/alerts/incidentRules/details.spec.jsx +++ b/tests/js/spec/views/alerts/incidentRules/details.spec.jsx @@ -1,7 +1,7 @@ import {Fragment} from 'react'; -import {mountWithTheme} from 'sentry-test/enzyme'; import {initializeOrg} from 'sentry-test/initializeOrg'; +import {fireEvent, mountWithTheme, screen} from 'sentry-test/reactTestingLibrary'; import GlobalModal from 'app/components/globalModal'; import {metric} from 'app/utils/analytics'; @@ -72,7 +72,7 @@ describe('Incident Rules Details', function () { body: rule, }); - const wrapper = mountWithTheme( + mountWithTheme( , - routerContext + {context: routerContext} ); - await tick(); - wrapper.update(); - // has existing trigger - expect(wrapper.find('input[name="criticalThreshold"]').first().prop('value')).toEqual( - 70 - ); - expect(wrapper.find('input[name="resolveThreshold"]').first().prop('value')).toEqual( - 36 - ); + expect(screen.getByTestId('critical-threshold')).toHaveValue('70'); + expect(screen.getByTestId('resolve-threshold')).toHaveValue('36'); expect(req).toHaveBeenCalled(); // Check correct rule name is called expect(onChangeTitleMock).toHaveBeenCalledWith(rule.name); - wrapper - .find('input[name="warningThreshold"]') - .first(1) - .simulate('change', {target: {value: 13}}); - wrapper - .find('input[name="resolveThreshold"]') - .first() - .simulate('change', {target: {value: 12}}); + fireEvent.change(screen.getByTestId('warning-threshold'), {target: {value: 13}}); + fireEvent.change(screen.getByTestId('resolve-threshold'), {target: {value: 12}}); // Create a new action - wrapper.find('button[aria-label="Add Action"]').simulate('click'); + fireEvent.click(screen.getByLabelText('Add Action')); // Save Trigger - wrapper.find('button[aria-label="Save Rule"]').simulate('submit'); + fireEvent.submit(screen.getByLabelText('Save Rule')); expect(metric.startTransaction).toHaveBeenCalledWith({name: 'saveAlertRule'}); expect(editRule).toHaveBeenCalledWith( @@ -161,26 +148,18 @@ describe('Incident Rules Details', function () { ); // New Trigger should be in list - await tick(); - wrapper.update(); - // Has correct values - expect(wrapper.find('input[name="criticalThreshold"]').first().prop('value')).toBe( - 70 - ); - expect(wrapper.find('input[name="warningThreshold"]').first().prop('value')).toBe(13); - expect(wrapper.find('input[name="resolveThreshold"]').first().prop('value')).toBe(12); + expect(screen.getByTestId('critical-threshold')).toHaveValue('70'); + expect(screen.getByTestId('warning-threshold')).toHaveValue('13'); + expect(screen.getByTestId('resolve-threshold')).toHaveValue('12'); editRule.mockReset(); // Clear warning Trigger - wrapper - .find('input[name="warningThreshold"]') - .first() - .simulate('change', {target: {value: ''}}); + fireEvent.change(screen.getByTestId('warning-threshold'), {target: {value: ''}}); // Save Trigger - wrapper.find('button[aria-label="Save Rule"]').simulate('submit'); + fireEvent.submit(screen.getByLabelText('Save Rule')); expect(editRule).toHaveBeenCalledWith( expect.anything(), diff --git a/tests/js/spec/views/alerts/incidentRules/triggersChart.spec.jsx b/tests/js/spec/views/alerts/incidentRules/triggersChart.spec.jsx index 5c6aae897eee93..54a53ce2b03a3d 100644 --- a/tests/js/spec/views/alerts/incidentRules/triggersChart.spec.jsx +++ b/tests/js/spec/views/alerts/incidentRules/triggersChart.spec.jsx @@ -1,5 +1,5 @@ -import {mountWithTheme} from 'sentry-test/enzyme'; import {initializeOrg} from 'sentry-test/initializeOrg'; +import {mountWithTheme} from 'sentry-test/reactTestingLibrary'; import {Client} from 'app/api'; import AreaChart from 'app/components/charts/areaChart'; @@ -42,7 +42,7 @@ describe('Incident Rules Create', () => { aggregate="count()" triggers={[]} />, - routerContext + {context: routerContext} ); await tick(); @@ -105,7 +105,7 @@ describe('Incident Rules Create', () => { aggregate="count()" triggers={[]} />, - routerContext + {context: routerContext} ); await tick(); diff --git a/tests/js/spec/views/alerts/wizard/radioPanelGroup.spec.jsx b/tests/js/spec/views/alerts/wizard/radioPanelGroup.spec.jsx index 76f0fe551b210d..e41424eb6619d3 100644 --- a/tests/js/spec/views/alerts/wizard/radioPanelGroup.spec.jsx +++ b/tests/js/spec/views/alerts/wizard/radioPanelGroup.spec.jsx @@ -1,4 +1,4 @@ -import {mountWithTheme} from 'sentry-test/enzyme'; +import {fireEvent, mountWithTheme, screen} from 'sentry-test/reactTestingLibrary'; import RadioGroupPanel from 'app/views/alerts/wizard/radioPanelGroup'; @@ -6,7 +6,7 @@ describe('RadioGroupPanel', function () { it('calls onChange when clicked', function () { const mock = jest.fn(); - const wrapper = mountWithTheme( + mountWithTheme( ); - wrapper.find('[role="radio"] Radio').last().simulate('change'); + + fireEvent.click(screen.getByText('Choice Three')); + expect(mock).toHaveBeenCalledWith(expect.any(String), expect.any(Object)); }); it('Renders extra content', function () { const mock = jest.fn(); - const wrapper = mountWithTheme( + mountWithTheme( ); - expect(wrapper.text().includes('extra content')).toEqual(true); + expect(screen.getByText('extra content')).toBeInTheDocument(); }); });