Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotlight: true comment to relevant Sentry.init snippets #535

Closed
Lms24 opened this issue Feb 13, 2024 · 5 comments
Closed

Add spotlight: true comment to relevant Sentry.init snippets #535

Lms24 opened this issue Feb 13, 2024 · 5 comments

Comments

@Lms24
Copy link
Member

Lms24 commented Feb 13, 2024

Our wizard should inject a commented spotlight: true flag to enable sending events from the SDK to the spotlight sidecar:

Sentry.init({
  dsn: '...',
  //...
  // uncomment this to enable Spotlight (https://spotlightjs.com):
  // spotlight: true
})

For now, the following platforms come to mind:

  • NextJS server-side
  • SvelteKit server-side
  • Remix server-side

Client-side is taken care of by the spotlight overlay (which injects the integration into the Sentry SDK).

Also

  • React Native (?)
  • Electron (?)
  • Not sure about the state in iOS/Android
@Shubhdeep12
Copy link
Contributor

Hey @Lms24 should we do this? For the platforms where we spotlight is supported.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 5, 2024
@Lms24
Copy link
Member Author

Lms24 commented Mar 5, 2024

Hey, @Shubhdeep12 yes, let's give this a try! If you take a look at this, let's please first tackle the JS frameworks with one PR per framework (to keep things a bit easier to review and revert if necessary). Let me know if you have questions around the wizard.

@Shubhdeep12
Copy link
Contributor

Sure, i'll do it in the same way.

@Shubhdeep12
Copy link
Contributor

Hi @Lms24 Added the PRs

Please check.
Thanks

@Lms24
Copy link
Member Author

Lms24 commented Dec 10, 2024

EDIT: reworded the reply because I mixed it up with #547

I'm going to close this issue because the comment-based approach was initially implemented in RN, SvelteKit and NextJS. However due to work in #622, it was removed again from NextJS. In the future, we'll make spotlight a selectable feature like tracing and replay. However, this we'll only do when the time is right.

@Lms24 Lms24 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@Lms24 Lms24 closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants