-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle size needs to be part of CI #65
Comments
With #451 we already have all we need. |
Update on the current state:
with the above being said, we could add a new workflow centered around this issue - i.e. build the integration test app without SDK, copy the app, then build it with the sdk. That's the way we do it on some of the other SDKs, e.g. RN, Flutter, Java, ... |
The size of the SDK is critical to many customers.
During CI we should measure the size and post as a commit to the PR.
Some ideas are: measure the size of all the
.dll
files inhttps://github.com/getsentry/sentry-unity/tree/main/package-dev/Runtime
.This obviously doesn't mean a lot since the linker would drop a lot of code, particularly from the dependencies.
Ideally we'd build the sample app (with IL2CPP for a platform such as Android), then remove Sentry as a dependency and build it again. Since the sample uses pretty much all public API, it'll be a very realistic number. Customers can expect that overhead or less, depending on their usage of the SDK.
Relates to: getsentry/sentry-java#1303
The text was updated successfully, but these errors were encountered: