From 24853a9745650f1f84dfbdfc58ddcdf4142b5141 Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Wed, 19 Feb 2025 16:48:34 +0100 Subject: [PATCH 1/3] fix(ios): When collect-modules fails to find a node path exit without errors When the log has `error:` prefix xcode will exit with non-zero exit code. --- packages/core/scripts/collect-modules.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/scripts/collect-modules.sh b/packages/core/scripts/collect-modules.sh index 419d2e4ac2..69cadaf0e9 100755 --- a/packages/core/scripts/collect-modules.sh +++ b/packages/core/scripts/collect-modules.sh @@ -45,7 +45,7 @@ else fi type $nodePath >/dev/null 2>&1 || { - echo >&2 "error: $nodePath not found! Modules won't be collected." \ + echo >&2 "[sentry/collect-modules.sh] $nodePath not found! Modules won't be collected." \ "Please export NODE_BINARY in 'Build Phase' - 'Bundle React Native code and images'" \ "to an absolute path of your node binary. Check your node path by 'which node'." exit 0 # Don't fail the build but inform about the problem From 78995e6e49032593a88aaa6285b5c6afe27cda0a Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Wed, 19 Feb 2025 16:50:12 +0100 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index de2c93b5cb..800a7585f9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ ### Fixes +- Remove `error:` prefix from `collect-modules.sh` to avoid failing iOS builds ([#4570](https://github.com/getsentry/sentry-react-native/pull/4570)) - Various crashes and issues of Session Replay on Android. See the Android SDK version bump for more details. ([#4529](https://github.com/getsentry/sentry-react-native/pull/4529)) ### Dependencies From 4c62cf6766bb7ce9b447137562ba7c84c6e3a527 Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Wed, 19 Feb 2025 16:51:20 +0100 Subject: [PATCH 3/3] Update collect-modules.sh --- packages/core/scripts/collect-modules.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/scripts/collect-modules.sh b/packages/core/scripts/collect-modules.sh index 69cadaf0e9..8dff6249bd 100755 --- a/packages/core/scripts/collect-modules.sh +++ b/packages/core/scripts/collect-modules.sh @@ -45,7 +45,7 @@ else fi type $nodePath >/dev/null 2>&1 || { - echo >&2 "[sentry/collect-modules.sh] $nodePath not found! Modules won't be collected." \ + echo "[sentry/collect-modules.sh] $nodePath not found! Modules won't be collected." \ "Please export NODE_BINARY in 'Build Phase' - 'Bundle React Native code and images'" \ "to an absolute path of your node binary. Check your node path by 'which node'." exit 0 # Don't fail the build but inform about the problem