misc: Split react-native and macos samples
#4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (new) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
antonis
reviewed
Oct 1, 2024
Android (legacy) Performance metrics 🚀
|
|
I fixed the CI now it's ready for review. |
antonis
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
The changes and file moves LGTM 🎉
Noting that I faced issues building the macos project locally with the new architecture. Cleaning up my local setup and using yarn pod-install-legacy worked for me both from xcode 16 and the command line (yarn react-native run-macos)
9 tasks
I've opened a PR for this #4138 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR moves the macos sample project under standalone react-native project. This enables us to not depended on the
react-native-macosversion and compatibility withreact-native. Using standalone project we can keep thereact-nativeon the latest RN version andreact-native-macossample on the latest RN version supported by the macos fork.💡 Motivation and Context
This helps up debugging the following issues iOS Sourcemaps are not uploaded using react native 0.75.[1-3] #4120
fixes: Move
react-native-macossample to a standalone application #3980💚 How did you test it?
ci build job, build and run the app locally
📝 Checklist
sendDefaultPIIis enabled#skip-changelog