New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refrain from overwriting the span status for unfinished spans #3216

Open

Tracked by

krystofwoldrich opened this issue Jul 28, 2023 · 0 comments

Open

Tracked by

Refrain from overwriting the span status for unfinished spans #3216

krystofwoldrich opened this issue Jul 28, 2023 · 0 comments

Labels

Platform: React-Native

Member

krystofwoldrich commented Jul 28, 2023 •

edited

Loading

Description

Summary: Not finished spans on Transaction finish should be left as is. The relay will change the span status and add an end timestamp.

JS SDK sets the status here, RN SDK doesn't have its own logic for this.
https://github.com/getsentry/sentry-javascript/blob/500fc66775ee1b9d57d4ce4508593611ca3a84df/packages/core/src/tracing/idletransaction.ts#L155-L156

backlink Refrain from overwriting the span status for unfinished spans team-mobile#128

Note: This is a breaking change for self-hosted users.

krystofwoldrich added the Platform: React-Native label

krystofwoldrich added this to Mobile & Cross Platform SDK

github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK

krystofwoldrich moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK

krystofwoldrich mentioned this issue

Refrain from overwriting the span status for unfinished spans getsentry/team-mobile#128

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment