Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CLI failures (e.g. server connecting issues in build time) #2413

Closed
5 of 11 tasks
n-kulic opened this issue Aug 7, 2022 · 2 comments
Closed
5 of 11 tasks

Allow CLI failures (e.g. server connecting issues in build time) #2413

n-kulic opened this issue Aug 7, 2022 · 2 comments

Comments

@n-kulic
Copy link

n-kulic commented Aug 7, 2022

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 2.4.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 2.4.0

react-native version: 0.63.4

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

Configuration:

(@sentry/react-native)

Sentry.init({
    dsn: SENTRY_DSN,
    environment: 'dev'
})

I have following issue:

In IOS build process it happens that a request is made to our Sentry server, and if Sentry server is temporary down (in our case it happens often), an error throws:

-error: API request failed
  caused by: sentry reported an error: gateway timeout (http status: 504)
Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.

I would like to allow CLI failure because it currently makes CI/CD pipeline to fail.
In @sentry/webpack-plugin there is an option to override default error handler and allow CLI failure, is there a similar option in @sentry/react-native as well?
* source: https://github.com/getsentry/sentry-webpack-plugin#options (errorHandler)

Steps to reproduce:

  • Add Sentry to newly created app and initialize it Sentry.init(..)
  • Close/stop Sentry server
  • Try to build IOS project

Actual result:

Build fails because Sentry server isn't responsive.

Expected result:

Allow CLI failures as in case when there are issues connecting to Sentry server (5xx error)

@nurycaroline
Copy link

Same issue here.

@marandaneto
Copy link
Contributor

We are already tracking this issue here, thanks for raising it.

Repository owner moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants