From bef6d482631fcbada0ed7794566c6832ef92cc69 Mon Sep 17 00:00:00 2001 From: Tarjei Huse Date: Fri, 30 Oct 2015 11:45:18 +0100 Subject: [PATCH 1/3] Log arguments in extra so that they do not need to be stringified Log arguments in extra so that they do not need to be stringified. This provides more context for use when debugging errors. --- plugins/console.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/console.js b/plugins/console.js index 4007ade598da..0bf2a4702c19 100644 --- a/plugins/console.js +++ b/plugins/console.js @@ -23,7 +23,7 @@ var logForGivenLevel = function(level) { if (level === 'warn') level = 'warning'; return function () { var args = [].slice.call(arguments); - Raven.captureMessage('' + args, {level: level, logger: 'console'}); + Raven.captureMessage(args[0], {level: level, logger: 'console', extra: { args: args }}); // this fails for some browsers. :( if (originalConsoleLevel) { From 954326b0acfb965a970731ea7cf3d3c00e206475 Mon Sep 17 00:00:00 2001 From: Tarjei Huse Date: Fri, 30 Oct 2015 11:45:54 +0100 Subject: [PATCH 2/3] Update console.js --- plugins/console.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/console.js b/plugins/console.js index 0bf2a4702c19..604c8635b11f 100644 --- a/plugins/console.js +++ b/plugins/console.js @@ -23,7 +23,7 @@ var logForGivenLevel = function(level) { if (level === 'warn') level = 'warning'; return function () { var args = [].slice.call(arguments); - Raven.captureMessage(args[0], {level: level, logger: 'console', extra: { args: args }}); + Raven.captureMessage('' + args[0], {level: level, logger: 'console', extra: { args: args }}); // this fails for some browsers. :( if (originalConsoleLevel) { From 77e4c8c1fe2b1f512632e1ac77163b31e3e2d6ae Mon Sep 17 00:00:00 2001 From: Tarjei Huse Date: Fri, 30 Oct 2015 20:08:31 +0100 Subject: [PATCH 3/3] change key from args to arguments So the intent becomes more clear. --- plugins/console.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/console.js b/plugins/console.js index 604c8635b11f..07f7e0fec834 100644 --- a/plugins/console.js +++ b/plugins/console.js @@ -23,7 +23,7 @@ var logForGivenLevel = function(level) { if (level === 'warn') level = 'warning'; return function () { var args = [].slice.call(arguments); - Raven.captureMessage('' + args[0], {level: level, logger: 'console', extra: { args: args }}); + Raven.captureMessage('' + args[0], {level: level, logger: 'console', extra: { arguments: args }}); // this fails for some browsers. :( if (originalConsoleLevel) {