Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttling #679

Closed
cjmielke opened this issue Aug 9, 2016 · 4 comments
Closed

Throttling #679

cjmielke opened this issue Aug 9, 2016 · 4 comments
Assignees

Comments

@cjmielke
Copy link

cjmielke commented Aug 9, 2016

Is there a way to throttle the error reporting?

This plugin is working great for me, but I did find that on one particular page on my site, with some browsers, an old D3 library was producing many errors per second. With sentry enabled, the users browser would crash, I think because it was queuing up too many async requests. With sentry disabled, the client script would run just find (despite the errors in the console)

Ive noticed 'shouldSendCallback' ... maybe I could do something like logging the timestamp of every error report and block sending if its less than a second?

@benvinegar
Copy link
Contributor

shouldSendCallback would work here, but we could also introduce a maxErrors config option or something that could reset every URL change (e.g. for single page apps).

@cjmielke
Copy link
Author

I just found this older issue that had the same problems, and offers an implementation for those curious :

#435

@MaxBittker
Copy link
Contributor

also linking this issue with related to similar problems: #530

@kamilogorek
Copy link
Contributor

Sampling is already a thing now. MaxEvents is discussed here #767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants