Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raven-js "swallow" React Native js error redbox #488

Closed
qbig opened this issue Jan 22, 2016 · 5 comments
Closed

raven-js "swallow" React Native js error redbox #488

qbig opened this issue Jan 22, 2016 · 5 comments

Comments

@qbig
Copy link
Contributor

qbig commented Jan 22, 2016

The 'redbox' would not show up and also no error message would be logged to Android Studio console if Raven is configured in the index.android.js file. Or is it recommended to comment out Raven/Sentry code during development ?

screen shot 2016-01-22 at 4 25 26 pm

@mattmo
Copy link

mattmo commented Jan 25, 2016

I imagine you'll want to only install raven when not in dev mode. e.g. in index.XXX.js

if (!__DEV__) {
  Raven
    .config('https://https://<key>@app.getsentry.com/<project>', { release: RELEASE_ID })
    .install();
}

Seems like the Raven documentation should be updated to reflect this.

@benvinegar
Copy link
Contributor

The 'redbox' would not show up and also no error message would be logged to Android Studio console if Raven is configured in the index.android.js file.

Okay. I haven't yet experimented w/ React Native on Android. Was this on a real device, or using an emulator?

Or is it recommended to comment out Raven/Sentry code during development ?

It should work in development, but I'd probably create a different Project for development so that your development errors don't mingle with your production ones.

@qbig
Copy link
Contributor Author

qbig commented Jan 26, 2016

@mattmo Thanks for the workaround. @benvinegar It was on an genymotion simulator. Would give it a try on real device and update here.

@benvinegar
Copy link
Contributor

@qbig – is this issue solved by #492?

@benvinegar
Copy link
Contributor

Sentry now has a first-class React Native plugin that combines both JavaScript and native (iOS) frames in stack traces.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants