Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance problem with span cleanup in OTEL code #14177

Closed
AbhiPrasad opened this issue Nov 4, 2024 · 4 comments
Closed

Performance problem with span cleanup in OTEL code #14177

AbhiPrasad opened this issue Nov 4, 2024 · 4 comments
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@AbhiPrasad
Copy link
Member

Description

ref #14154

Previously raised in #14067

We had a huge performance problem with a overhead of 5x or so in CPU Load. We investigated the issue and saw that the cleanup logic for OTEL ran on every span end. Thats why we rewrote this to run only once every interval.

I do not guarantee that this code is perfect, this is just a hint, that there is something wrong currently.
@AbhiPrasad AbhiPrasad added Package-Meta: OpenTelemetry Package: node Issues related to the Sentry Node SDK labels Nov 4, 2024
@AbhiPrasad AbhiPrasad mentioned this issue Nov 4, 2024
Merged
2 tasks
@lforst lforst self-assigned this Nov 5, 2024
@HofmannZ
Copy link

HofmannZ commented Nov 8, 2024

We have the same issue, huge CPU load overhead after upgrading Sentry.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 8, 2024
@lforst
Copy link
Member

lforst commented Nov 8, 2024

@HofmannZ I'll take a look today. I cannot promise when this will be fixed but I am aiming at early next week.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 3 Nov 8, 2024
@mydea mydea assigned mydea and unassigned lforst Nov 12, 2024
@mydea mydea assigned lforst and unassigned mydea Nov 26, 2024
@lforst
Copy link
Member

lforst commented Nov 27, 2024

We just released version 8.41.0 which should hopefully solve this perf issue. Let us know if it worked!

@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 3 Nov 27, 2024
@lforst lforst removed their assignment Dec 2, 2024
@AbhiPrasad
Copy link
Member Author

Closing this for now. If there are any performance regressions please let us know, we'll re-open the issue and keep investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mydea @lforst @HofmannZ @AbhiPrasad