Part of the stack trace can go missing in Electron on Windows

[teleclimber]

bug

Electron 1.7.8 (Chrome 58)
Windows 7
raven-js 3.17
Hosted Sentry

What is the current behavior?

Part of the stack trace is missing

What is the expected behavior?

The whole stack trace should be sent to Sentry.

The source of the problem is that the regex in tracekit.js fails to match the filename as it is produced by Chrome/Electron under certain conditions (in my case it involves running code from within an iframe).

Typically a frame has the following form:

   at SomeObject.someFunction (file:///C:/Users/path/to/file.js:123:56)

However in some cases it looks like this:

   at SomeObject.someFunction (C:\Users\path\to\file.js:123:56)

Note the lack of file:/// and the Windows-style backslashes.

Could the regex be updated to support this case please? Thank-you.

[kamilogorek]

Hey @teleclimber, would you mind providing a test case and PR with updated regexp?

[teleclimber]

Ok so I have made a change in my fork that fixes the problem, and added tests. Everything passes.

However it looks like your pre-commit linter made hundreds of changes in one of the files.

I can PR it or you can tell me how you want to handle this?

master...teleclimber:master

[kamilogorek]

Thanks. Yes, precommit passed the file through prettier, and because it wasn't edited in a long time, it has been updated to up-to-date code style.
It's totally fine the way it is, but could you just split those changes and yours into two separate commits? It'll be easier to distinguish them later.