Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect cold app start measurement when the app was opened after recev push notification receive #3567

Closed
zhukic opened this issue Jul 11, 2024 · 6 comments
Assignees
Labels
Platform: Android Type: Bug Something isn't working

Comments

@zhukic
Copy link

zhukic commented Jul 11, 2024

Integration

sentry-android

Build System

Gradle

AGP Version

8.4.2

Proguard

Enabled

Version

7.9.0

Steps to Reproduce

Hi!

We noticed incorrect values for app.start.cold metric, and we managed to reproduce it if a push notification is received and the app is opened after some time(minutes or hours).

11

I see that it duplicates the #3538 #3329 issues, but I decided to create a separate one because it may be a different case.

I also see that some fix is on the way, and it would be good to know if the fix also solves my problem.

Sentry Gradle plugin version: 4.6.0
Performance V2 enabled

Thank you!

Expected Result

Incorrect app.start.cold values.

Actual Result

Do not report cold app start in such cases?

@kahest
Copy link
Member

kahest commented Jul 11, 2024

Hey @zhukic thanks for reporting, especially with this important detail

reproduce it if a push notification is received and the app is opened after some time(minutes or hours).

As you mention, the open PR might fix this issue as well 👍
Out of curiosity - did you try/manage to reproduce this with Performance V2 turned off?

cc @stefanosiano @markushi

@zhukic
Copy link
Author

zhukic commented Jul 11, 2024

@kahest

did you try/manage to reproduce this with Performance V2 turned off?

I haven't tried to reproduce with V2 turned off but I can try if it may help somehow

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 11, 2024
@kahest
Copy link
Member

kahest commented Jul 12, 2024

@zhukic thanks for offering, no need atm - we'll try ourselves and get back to you in case we need more info

@stefanosiano stefanosiano self-assigned this Jul 12, 2024
@stefanosiano stefanosiano moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Jul 17, 2024
@zhukic
Copy link
Author

zhukic commented Jul 22, 2024

@kahest Hi!
I see that you merged the fix. Could you please explain how the SDK will behave in case of push notifications after the fix?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 22, 2024
@kahest
Copy link
Member

kahest commented Jul 22, 2024

@zhukic the fix detects if the app was (likely) started in background (e.g. via PN) before it actually became active, and in that case reports the transaction as a screen load event without incorrect app start timings. We plan to ship a hotfix release for this soon and would appreciate feedback.

@stefanosiano
Copy link
Member

@zhukic The fix was released in the SDK version 7.12.1.
Please, reopen this issue in case the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Type: Bug Something isn't working
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants