Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier way of filtering errors for GraphQL #2899

Closed
adinauer opened this issue Aug 17, 2023 Discussed in #2897 · 2 comments · Fixed by #2967
Closed

Easier way of filtering errors for GraphQL #2899

adinauer opened this issue Aug 17, 2023 Discussed in #2897 · 2 comments · Fixed by #2967
Assignees
@adinauer
Labels
Platform: Java

Comments

@adinauer
Copy link
Member

Discussed in #2897

We could add a List<ErrorClassification> of ignored errors, e.g. as constructor parameter for SentryInstrumentation.

An additional thing to do might be to pass the ErrorClassification in Hint for people not wanting to manually configure SentryInstrumentation when using spring-graphql where we offer auto configuration. This way it might be easier to filter using beforeSend etc.
@adinauer adinauer mentioned this issue Sep 26, 2023
Closed
@adinauer
Copy link
Member Author

When implementing also consider feedback in #2953

@adinauer adinauer self-assigned this Oct 4, 2023
@adinauer adinauer mentioned this issue Oct 5, 2023
Merged
7 tasks
@adinauer
Copy link
Member Author

@ptrnk91 @SalyczeQ 6.31.0 has just been released and allows filtering GraphQL errors.

You can now set a List<String> directly when calling the constructor of SentryInstrumentation. For Spring Boot it can also be set in application.properties as sentry.graphql.ignored-error-types=SOME_ERROR,ANOTHER_ERROR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adinauer adinauer

Labels
Platform: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow filtering graphql errors getsentry/sentry-java
1 participant
@adinauer