Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected char 0xe1 at 7 in SENTRY-APOLLO-3-VARIABLES value: {name=á} #2680

Closed
Syer10 opened this issue Apr 27, 2023 · 3 comments · Fixed by #2707
Closed

Unexpected char 0xe1 at 7 in SENTRY-APOLLO-3-VARIABLES value: {name=á} #2680

Syer10 opened this issue Apr 27, 2023 · 3 comments · Fixed by #2707
Assignees

Comments

@Syer10
Copy link

Syer10 commented Apr 27, 2023

Integration

sentry-apollo-3

Java Version

17

Version

6.17.0

Steps to Reproduce

  1. Write a GraphQL query that takes variables
  2. Input non-ASCII character in the variable, such as á
  3. Query fails

Expected Result

The query goes through and works, like it does without the Sentry interceptor.

Actual Result

Exception in thread “AWT-EventQueue-0” com.apollographql.apollo3.exception.ApolloNetworkException: Unexpected char 0xe1 at 7 in SENTRY-APOLLO-3-VARIABLES value: {name=á}.

Based on my research, non-ASCII characters are not usually allowed in headers, while it may work for some clients, it may not for others. Users have suggested using Base64 to work around this issue, which may be what Sentry needs to do.

@romtsn
Copy link
Member

romtsn commented May 2, 2023

@Syer10 Thanks for reporting and the suggested workaround, we'll look into this!

@adinauer
Copy link
Member

adinauer commented May 3, 2023

Encoding and decoding values seems like a good approach. @lbloder will take a look.

@markushi markushi moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK May 3, 2023
@lbloder
Copy link
Collaborator

lbloder commented May 4, 2023

Hi @Syer10,
I'm currently looking into this. However, it seems like I'm unable to reproduce the issue within our Test-Suite.
Could you provide a minimum sample that causes this issue? Alternatively, could you provide a bit more detail on the system/tech-stack/client this issue arises on?

We want to make sure that this is reproducible in our Test-Suite so we can make sure it keeps working as expected after the fix.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants