Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window.FEATURE_NO_TITLE does not work when activity traces or activity-lifecycle breadcrumbs enabled #1768

Closed
marandaneto opened this issue Oct 18, 2021 · 2 comments · Fixed by #1769
Closed

Window.FEATURE_NO_TITLE does not work when activity traces or activity-lifecycle breadcrumbs enabled #1768

marandaneto opened this issue Oct 18, 2021 · 2 comments · Fixed by #1769
Labels
Platform: Android Type: Bug Something isn't working

Comments

@marandaneto
Copy link
Contributor

if using requestWindowFeature(Window.FEATURE_NO_TITLE), title bar is still visible.

workaround:

<meta-data android:name="io.sentry.traces.activity.enable" android:value="false" />
<meta-data android:name="io.sentry.breadcrumbs.activity-lifecycle" android:value="false" />
@marandaneto marandaneto added Type: Bug Something isn't working Platform: Android labels Oct 18, 2021
@marandaneto
Copy link
Contributor Author

might be similar to #1659

@marandaneto
Copy link
Contributor Author

the culprit is calling activityFramesTracker.addActivity(activity); in the onActivityCreated lifecycle method.

https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java#L230

@marandaneto marandaneto mentioned this issue Oct 18, 2021
Merged
4 tasks
@marandaneto marandaneto mentioned this issue Oct 18, 2021
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Android Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Window.FEATURE_NO_TITLE does not work when using activity traces getsentry/sentry-java
1 participant
@marandaneto