Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge user IP with {{auto}} if IP is null and sendDefaultPii is enabled, for events and transactions #1427

Closed
marandaneto opened this issue Apr 21, 2021 · 3 comments
Closed

Merge user IP with {{auto}} if IP is null and sendDefaultPii is enabled, for events and transactions #1427

marandaneto opened this issue Apr 21, 2021 · 3 comments
Assignees
@maciejwalkowiak
Labels
enhancement New feature or request

Comments

@marandaneto
Copy link
Contributor

#1424 (comment)
@marandaneto marandaneto added the enhancement New feature or request label Apr 21, 2021
@marandaneto marandaneto mentioned this issue Apr 21, 2021
Merged
4 tasks
@marandaneto
Copy link
Contributor Author

MainEventProcessor#mergeUser does it, we just need to extract this and call from multiple places when setting the user

@maciejwalkowiak maciejwalkowiak self-assigned this Jun 25, 2021
@maciejwalkowiak
Copy link
Contributor

Isn't this already implemented? I don't see what's missing.

@marandaneto
Copy link
Contributor Author

I think that this has been automatically solved when executing event processors for transactions too, so if you don't see this missing anywhere, just close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciejwalkowiak maciejwalkowiak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maciejwalkowiak @marandaneto