diff --git a/CHANGELOG.md b/CHANGELOG.md index 10ad78af32..8655a966af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - Fix `Gpu.vendorId` should be a String ([#2343](https://github.com/getsentry/sentry-java/pull/2343)) +- Don't set device name on Android if `sendDefaultPii` is disabled ([#2354](https://github.com/getsentry/sentry-java/pull/2354)) ### Features diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1dff57ad25..8a21647bcc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,7 @@ We suggest opening an issue to discuss bigger changes before investing on a big # Requirements -The project currently requires you run JDK 11. +The project currently requires you run JDK 17. ## Android diff --git a/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java b/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java index 0159f02ff1..bf17d90aab 100644 --- a/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java +++ b/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java @@ -94,6 +94,7 @@ public DefaultAndroidEventProcessor( ExecutorService executorService = Executors.newSingleThreadExecutor(); // dont ref. to method reference, theres a bug on it + //noinspection Convert2MethodRef contextData = executorService.submit(() -> loadContextData()); executorService.shutdown(); @@ -282,7 +283,9 @@ private void setArchitectures(final @NotNull Device device) { // TODO: missing usable memory Device device = new Device(); - device.setName(getDeviceName()); + if (options.isSendDefaultPii()) { + device.setName(getDeviceName()); + } device.setManufacturer(Build.MANUFACTURER); device.setBrand(Build.BRAND); device.setFamily(getFamily());