From 6a35dad6221c9d28ccf78e7816587066c4aec038 Mon Sep 17 00:00:00 2001 From: vishnukvmd Date: Sun, 29 May 2022 04:28:01 +0530 Subject: [PATCH 1/5] Move to local dependency --- flutter/pubspec.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/flutter/pubspec.yaml b/flutter/pubspec.yaml index 959b7f8bcf..3689920d12 100644 --- a/flutter/pubspec.yaml +++ b/flutter/pubspec.yaml @@ -14,7 +14,8 @@ dependencies: sdk: flutter flutter_web_plugins: sdk: flutter - sentry: ^6.5.1 + sentry: + path: ../dart package_info_plus: ^1.0.0 meta: ^1.3.0 From 1ba4085ad44496f37392ae9172393d741fe65b75 Mon Sep 17 00:00:00 2001 From: vishnukvmd Date: Sun, 29 May 2022 04:42:20 +0530 Subject: [PATCH 2/5] Pass DSN within the SentryEnvelopeHeader --- dart/lib/src/sentry_client.dart | 1 + dart/lib/src/sentry_envelope.dart | 9 +++++---- dart/lib/src/sentry_envelope_header.dart | 11 +++++++++-- dart/test/mocks.dart | 5 ++++- dart/test/sentry_envelope_header_test.dart | 4 ++-- dart/test/sentry_envelope_test.dart | 11 +++++++++-- dart/test/sentry_envelope_vm_test.dart | 4 +++- dart/test/transport/http_transport_test.dart | 14 +++++++++----- dio/test/mocks.dart | 3 +++ flutter/test/file_system_transport_test.dart | 9 ++++++--- 10 files changed, 51 insertions(+), 20 deletions(-) diff --git a/dart/lib/src/sentry_client.dart b/dart/lib/src/sentry_client.dart index 020be3046e..8990bde736 100644 --- a/dart/lib/src/sentry_client.dart +++ b/dart/lib/src/sentry_client.dart @@ -108,6 +108,7 @@ class SentryClient { final envelope = SentryEnvelope.fromEvent( preparedEvent, _options.sdk, + _options.dsn, attachments: scope?.attachements, ); diff --git a/dart/lib/src/sentry_envelope.dart b/dart/lib/src/sentry_envelope.dart index 25bd031974..492bce048f 100644 --- a/dart/lib/src/sentry_envelope.dart +++ b/dart/lib/src/sentry_envelope.dart @@ -21,11 +21,12 @@ class SentryEnvelope { /// Create an [SentryEnvelope] with containing one [SentryEnvelopeItem] which holds the [SentryEvent] data. factory SentryEnvelope.fromEvent( SentryEvent event, - SdkVersion sdkVersion, { + SdkVersion sdkVersion, + String? dsn, { List? attachments, }) { return SentryEnvelope( - SentryEnvelopeHeader(event.eventId, sdkVersion), + SentryEnvelopeHeader(event.eventId, sdkVersion, dsn), [ SentryEnvelopeItem.fromEvent(event), if (attachments != null) @@ -39,7 +40,7 @@ class SentryEnvelope { SdkVersion sdkVersion, ) { return SentryEnvelope( - SentryEnvelopeHeader(feedback.eventId, sdkVersion), + SentryEnvelopeHeader(feedback.eventId, sdkVersion, null), [SentryEnvelopeItem.fromUserFeedback(feedback)], ); } @@ -51,7 +52,7 @@ class SentryEnvelope { List? attachments, }) { return SentryEnvelope( - SentryEnvelopeHeader(transaction.eventId, sdkVersion), + SentryEnvelopeHeader(transaction.eventId, sdkVersion, null), [ SentryEnvelopeItem.fromTransaction(transaction), if (attachments != null) diff --git a/dart/lib/src/sentry_envelope_header.dart b/dart/lib/src/sentry_envelope_header.dart index 426bccc910..49d87ce35f 100644 --- a/dart/lib/src/sentry_envelope_header.dart +++ b/dart/lib/src/sentry_envelope_header.dart @@ -3,10 +3,11 @@ import 'protocol/sdk_version.dart'; /// Header containing `SentryId` and `SdkVersion`. class SentryEnvelopeHeader { - SentryEnvelopeHeader(this.eventId, this.sdkVersion); + SentryEnvelopeHeader(this.eventId, this.sdkVersion, this.dsn); SentryEnvelopeHeader.newEventId() : eventId = SentryId.newId(), - sdkVersion = null; + sdkVersion = null, + dsn = null; /// The identifier of encoded `SentryEvent`. final SentryId? eventId; @@ -14,6 +15,9 @@ class SentryEnvelopeHeader { /// The `SdkVersion` with which the envelope was send. final SdkVersion? sdkVersion; + /// The `DSN` of the Sentry project. + final String? dsn; + /// Header encoded as JSON Map toJson() { final json = {}; @@ -25,6 +29,9 @@ class SentryEnvelopeHeader { if (tempSdkVersion != null) { json['sdk'] = tempSdkVersion.toJson(); } + if (dsn != null) { + json['dsn'] = dsn; + } return json; } } diff --git a/dart/test/mocks.dart b/dart/test/mocks.dart index cb36172d06..4c0aa47307 100644 --- a/dart/test/mocks.dart +++ b/dart/test/mocks.dart @@ -129,7 +129,10 @@ typedef EventProcessorFunction = FutureOr Function(SentryEvent event, {dynamic hint}); var fakeEnvelope = SentryEnvelope.fromEvent( - fakeEvent, SdkVersion(name: 'sdk1', version: '1.0.0')); + fakeEvent, + SdkVersion(name: 'sdk1', version: '1.0.0'), + fakeDsn, +); class MockRateLimiter implements RateLimiter { bool filterReturnsNull = false; diff --git a/dart/test/sentry_envelope_header_test.dart b/dart/test/sentry_envelope_header_test.dart index 28f894e766..cedc01ebd9 100644 --- a/dart/test/sentry_envelope_header_test.dart +++ b/dart/test/sentry_envelope_header_test.dart @@ -5,7 +5,7 @@ import 'package:test/test.dart'; void main() { group('SentryEnvelopeHeader', () { test('toJson empty', () { - final sut = SentryEnvelopeHeader(null, null); + final sut = SentryEnvelopeHeader(null, null, null); final expected = {}; expect(sut.toJson(), expected); }); @@ -16,7 +16,7 @@ void main() { name: 'fixture-sdkName', version: 'fixture-version', ); - final sut = SentryEnvelopeHeader(eventId, sdkVersion); + final sut = SentryEnvelopeHeader(eventId, sdkVersion, null); final expextedSkd = sdkVersion.toJson(); final expected = { 'event_id': eventId.toString(), diff --git a/dart/test/sentry_envelope_test.dart b/dart/test/sentry_envelope_test.dart index bc28c508de..21141951c5 100644 --- a/dart/test/sentry_envelope_test.dart +++ b/dart/test/sentry_envelope_test.dart @@ -28,7 +28,7 @@ void main() { final item = SentryEnvelopeItem(itemHeader, dataFactory); - final header = SentryEnvelopeHeader(eventId, null); + final header = SentryEnvelopeHeader(eventId, null, null); final sut = SentryEnvelope(header, [item, item]); final expectedHeaderJson = header.toJson(); @@ -53,7 +53,9 @@ void main() { final sentryEvent = SentryEvent(eventId: eventId); final sdkVersion = SdkVersion(name: 'fixture-name', version: 'fixture-version'); - final sut = SentryEnvelope.fromEvent(sentryEvent, sdkVersion); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; + final sut = + SentryEnvelope.fromEvent(sentryEvent, sdkVersion, fakeDsn); final expectedEnvelopeItem = SentryEnvelopeItem.fromEvent(sentryEvent); @@ -111,16 +113,19 @@ void main() { final sentryEvent = SentryEvent(eventId: eventId); final sdkVersion = SdkVersion(name: 'fixture-name', version: 'fixture-version'); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final sut = SentryEnvelope.fromEvent( sentryEvent, sdkVersion, + fakeDsn, attachments: [attachment], ); final expectedEnvelopeItem = SentryEnvelope.fromEvent( sentryEvent, sdkVersion, + fakeDsn, ); final sutEnvelopeData = []; @@ -140,12 +145,14 @@ void main() { // This is a test for https://github.com/getsentry/sentry-dart/issues/523 test('serialize with non-serializable class', () async { final event = SentryEvent(extra: {'non-ecodable': NonEncodable()}); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final sut = SentryEnvelope.fromEvent( event, SdkVersion( name: 'test', version: '1', ), + fakeDsn, ); final _ = sut.envelopeStream(SentryOptions()).map((e) => e); diff --git a/dart/test/sentry_envelope_vm_test.dart b/dart/test/sentry_envelope_vm_test.dart index b1bd880f91..e345d68fae 100644 --- a/dart/test/sentry_envelope_vm_test.dart +++ b/dart/test/sentry_envelope_vm_test.dart @@ -28,7 +28,7 @@ void main() { final eventId = SentryId.fromId('3b382f22ee67491f80f7dee18016a7b1'); final sdkVersion = SdkVersion(name: 'test', version: 'version'); - final header = SentryEnvelopeHeader(eventId, sdkVersion); + final header = SentryEnvelopeHeader(eventId, sdkVersion, null); final envelope = SentryEnvelope(header, [attachmentItem]); final envelopeData = []; @@ -51,10 +51,12 @@ void main() { final sdkVersion = SdkVersion(name: '', version: ''); final attachment = IoSentryAttachment.fromPath('this_path_does_not_exist.txt'); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final envelope = SentryEnvelope.fromEvent( event, sdkVersion, + fakeDsn, attachments: [attachment], ); diff --git a/dart/test/transport/http_transport_test.dart b/dart/test/transport/http_transport_test.dart index 6b7319b5ee..a2e66bd550 100644 --- a/dart/test/transport/http_transport_test.dart +++ b/dart/test/transport/http_transport_test.dart @@ -16,7 +16,7 @@ import '../mocks.dart'; void main() { SentryEnvelope givenEnvelope() { - final filteredEnvelopeHeader = SentryEnvelopeHeader(SentryId.empty(), null); + final filteredEnvelopeHeader = SentryEnvelopeHeader(SentryId.empty(), null, null); final filteredItemHeader = SentryEnvelopeItemHeader(SentryItemType.event, () async { return 2; @@ -66,8 +66,9 @@ void main() { final sut = fixture.getSut(httpMock, mockRateLimiter); final sentryEvent = SentryEvent(); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk); + SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); await sut.send(envelope); final envelopeData = []; @@ -90,8 +91,9 @@ void main() { final sut = fixture.getSut(httpMock, mockRateLimiter); final sentryEvent = SentryEvent(); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk); + SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); final eventId = await sut.send(envelope); expect(eventId, SentryId.empty()); @@ -114,8 +116,9 @@ void main() { final sut = fixture.getSut(httpMock, mockRateLimiter); final sentryEvent = SentryEvent(); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk); + SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); await sut.send(envelope); expect(mockRateLimiter.envelopeToFilter?.header.eventId, @@ -135,8 +138,9 @@ void main() { final sut = fixture.getSut(httpMock, mockRateLimiter); final sentryEvent = SentryEvent(); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk); + SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); await sut.send(envelope); expect(mockRateLimiter.errorCode, 200); diff --git a/dio/test/mocks.dart b/dio/test/mocks.dart index b17a27e8b6..9bfdec85c5 100644 --- a/dio/test/mocks.dart +++ b/dio/test/mocks.dart @@ -128,9 +128,12 @@ class FunctionEventProcessor extends EventProcessor { typedef EventProcessorFunction = FutureOr Function(SentryEvent event, {dynamic hint}); +final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; + var fakeEnvelope = SentryEnvelope.fromEvent( fakeEvent, SdkVersion(name: 'sdk1', version: '1.0.0'), + fakeDsn, ); class MockRateLimiter implements RateLimiter { diff --git a/flutter/test/file_system_transport_test.dart b/flutter/test/file_system_transport_test.dart index 680deb073d..f8420d19e7 100644 --- a/flutter/test/file_system_transport_test.dart +++ b/flutter/test/file_system_transport_test.dart @@ -28,8 +28,9 @@ void main() { final event = SentryEvent(); final sdkVersion = SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent(event, sdkVersion); + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); final sentryId = await transport.send(envelope); expect(sentryId, sentryId); @@ -44,8 +45,9 @@ void main() { final event = SentryEvent(); final sdkVersion = SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent(event, sdkVersion); + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); final sentryId = await transport.send(envelope); expect(SentryId.empty(), sentryId); @@ -63,7 +65,8 @@ void main() { SentryEvent(message: SentryMessage('hi I am a special char ◤')); final sdkVersion = SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); - final envelope = SentryEnvelope.fromEvent(event, sdkVersion); + final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); await transport.send(envelope); final envelopeList = arguments as List; From a6fb6c0cae4db9abfcba5496c242017390244d18 Mon Sep 17 00:00:00 2001 From: vishnukvmd Date: Tue, 14 Jun 2022 21:12:30 +0530 Subject: [PATCH 3/5] Switch to remote dependency as an override is already declared --- flutter/pubspec.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/flutter/pubspec.yaml b/flutter/pubspec.yaml index 3689920d12..959b7f8bcf 100644 --- a/flutter/pubspec.yaml +++ b/flutter/pubspec.yaml @@ -14,8 +14,7 @@ dependencies: sdk: flutter flutter_web_plugins: sdk: flutter - sentry: - path: ../dart + sentry: ^6.5.1 package_info_plus: ^1.0.0 meta: ^1.3.0 From 3502ee4d534b9fcf47be2d89c0ae45a28044ef5e Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Tue, 27 Sep 2022 11:45:05 +0530 Subject: [PATCH 4/5] Fix broken tests --- dart/test/mocks.dart | 2 +- dart/test/sentry_envelope_header_test.dart | 2 +- dart/test/sentry_envelope_test.dart | 6 ++-- dart/test/sentry_envelope_vm_test.dart | 5 +--- dart/test/transport/http_transport_test.dart | 29 +++++++++++--------- flutter/test/file_system_transport_test.dart | 6 ++-- 6 files changed, 25 insertions(+), 25 deletions(-) diff --git a/dart/test/mocks.dart b/dart/test/mocks.dart index 4c0aa47307..836dccc762 100644 --- a/dart/test/mocks.dart +++ b/dart/test/mocks.dart @@ -131,7 +131,7 @@ typedef EventProcessorFunction = FutureOr var fakeEnvelope = SentryEnvelope.fromEvent( fakeEvent, SdkVersion(name: 'sdk1', version: '1.0.0'), - fakeDsn, + dsn: fakeDsn, ); class MockRateLimiter implements RateLimiter { diff --git a/dart/test/sentry_envelope_header_test.dart b/dart/test/sentry_envelope_header_test.dart index 92fbe9db5f..912a7ef9e3 100644 --- a/dart/test/sentry_envelope_header_test.dart +++ b/dart/test/sentry_envelope_header_test.dart @@ -5,7 +5,7 @@ import 'package:test/test.dart'; void main() { group('SentryEnvelopeHeader', () { test('toJson empty', () { - final sut = SentryEnvelopeHeader(null, null, null); + final sut = SentryEnvelopeHeader(null, null); final expected = {}; expect(sut.toJson(), expected); }); diff --git a/dart/test/sentry_envelope_test.dart b/dart/test/sentry_envelope_test.dart index 4878a788c9..d5b24a9d92 100644 --- a/dart/test/sentry_envelope_test.dart +++ b/dart/test/sentry_envelope_test.dart @@ -143,14 +143,14 @@ void main() { final sut = SentryEnvelope.fromEvent( sentryEvent, sdkVersion, - fakeDsn, + dsn: fakeDsn, attachments: [attachment], ); final expectedEnvelopeItem = SentryEnvelope.fromEvent( sentryEvent, sdkVersion, - fakeDsn, + dsn: fakeDsn, ); final sutEnvelopeData = []; @@ -177,7 +177,7 @@ void main() { name: 'test', version: '1', ), - fakeDsn, + dsn: fakeDsn, ); final _ = sut.envelopeStream(SentryOptions()).map((e) => e); diff --git a/dart/test/sentry_envelope_vm_test.dart b/dart/test/sentry_envelope_vm_test.dart index 569f6176ba..fdb136d9d6 100644 --- a/dart/test/sentry_envelope_vm_test.dart +++ b/dart/test/sentry_envelope_vm_test.dart @@ -27,7 +27,7 @@ void main() { final eventId = SentryId.fromId('3b382f22ee67491f80f7dee18016a7b1'); final sdkVersion = SdkVersion(name: 'test', version: 'version'); - final header = SentryEnvelopeHeader(eventId, sdkVersion, null); + final header = SentryEnvelopeHeader(eventId, sdkVersion); final envelope = SentryEnvelope(header, [attachmentItem]); final envelopeData = []; @@ -50,12 +50,9 @@ void main() { final sdkVersion = SdkVersion(name: '', version: ''); final attachment = IoSentryAttachment.fromPath('this_path_does_not_exist.txt'); - final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent( event, sdkVersion, - fakeDsn, attachments: [attachment], ); diff --git a/dart/test/transport/http_transport_test.dart b/dart/test/transport/http_transport_test.dart index 3f2b53770f..e8df1cf372 100644 --- a/dart/test/transport/http_transport_test.dart +++ b/dart/test/transport/http_transport_test.dart @@ -2,17 +2,16 @@ import 'dart:convert'; import 'package:http/http.dart' as http; import 'package:http/testing.dart'; +import 'package:sentry/sentry.dart'; import 'package:sentry/src/client_reports/discard_reason.dart'; import 'package:sentry/src/sentry_envelope_header.dart'; import 'package:sentry/src/sentry_envelope_item_header.dart'; import 'package:sentry/src/sentry_item_type.dart'; +import 'package:sentry/src/sentry_tracer.dart'; import 'package:sentry/src/transport/data_category.dart'; +import 'package:sentry/src/transport/http_transport.dart'; import 'package:sentry/src/transport/rate_limiter.dart'; import 'package:test/test.dart'; -import 'package:sentry/src/sentry_tracer.dart'; - -import 'package:sentry/sentry.dart'; -import 'package:sentry/src/transport/http_transport.dart'; import '../mocks.dart'; import '../mocks/mock_client_report_recorder.dart'; @@ -20,7 +19,7 @@ import '../mocks/mock_hub.dart'; void main() { SentryEnvelope givenEnvelope() { - final filteredEnvelopeHeader = SentryEnvelopeHeader(SentryId.empty(), null, null); + final filteredEnvelopeHeader = SentryEnvelopeHeader(SentryId.empty(), null); final filteredItemHeader = SentryEnvelopeItemHeader(SentryItemType.event, () async { return 2; @@ -71,8 +70,9 @@ void main() { final sentryEvent = SentryEvent(); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); + final envelope = SentryEnvelope.fromEvent( + sentryEvent, fixture.options.sdk, + dsn: fakeDsn); await sut.send(envelope); final envelopeData = []; @@ -96,8 +96,9 @@ void main() { final sentryEvent = SentryEvent(); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); + final envelope = SentryEnvelope.fromEvent( + sentryEvent, fixture.options.sdk, + dsn: fakeDsn); final eventId = await sut.send(envelope); expect(eventId, SentryId.empty()); @@ -121,8 +122,9 @@ void main() { final sentryEvent = SentryEvent(); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); + final envelope = SentryEnvelope.fromEvent( + sentryEvent, fixture.options.sdk, + dsn: fakeDsn); await sut.send(envelope); expect(mockRateLimiter.envelopeToFilter?.header.eventId, @@ -143,8 +145,9 @@ void main() { final sentryEvent = SentryEvent(); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = - SentryEnvelope.fromEvent(sentryEvent, fixture.options.sdk, fakeDsn); + final envelope = SentryEnvelope.fromEvent( + sentryEvent, fixture.options.sdk, + dsn: fakeDsn); await sut.send(envelope); expect(mockRateLimiter.errorCode, 200); diff --git a/flutter/test/file_system_transport_test.dart b/flutter/test/file_system_transport_test.dart index 57feea568c..fccb953ac8 100644 --- a/flutter/test/file_system_transport_test.dart +++ b/flutter/test/file_system_transport_test.dart @@ -34,7 +34,7 @@ void main() { SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, dsn: fakeDsn); final sentryId = await transport.send(envelope); expect(sentryId, sentryId); @@ -51,7 +51,7 @@ void main() { SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, dsn: fakeDsn); final sentryId = await transport.send(envelope); expect(SentryId.empty(), sentryId); @@ -70,7 +70,7 @@ void main() { final sdkVersion = SdkVersion(name: 'fixture-sdkName', version: 'fixture-sdkVersion'); final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - final envelope = SentryEnvelope.fromEvent(event, sdkVersion, fakeDsn); + final envelope = SentryEnvelope.fromEvent(event, sdkVersion, dsn: fakeDsn); await transport.send(envelope); final envelopeList = arguments as List; From bd6984854bf42ce69d4cfa4095d4f77bf30acb8b Mon Sep 17 00:00:00 2001 From: Neeraj Gupta <254676+ua741@users.noreply.github.com> Date: Wed, 28 Sep 2022 16:07:07 +0530 Subject: [PATCH 5/5] Fix test --- dio/test/mocks.dart | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dio/test/mocks.dart b/dio/test/mocks.dart index 9bfdec85c5..f12bc2c4aa 100644 --- a/dio/test/mocks.dart +++ b/dio/test/mocks.dart @@ -128,12 +128,10 @@ class FunctionEventProcessor extends EventProcessor { typedef EventProcessorFunction = FutureOr Function(SentryEvent event, {dynamic hint}); -final fakeDsn = 'https://abc@def.ingest.sentry.io/1234567'; - var fakeEnvelope = SentryEnvelope.fromEvent( fakeEvent, SdkVersion(name: 'sdk1', version: '1.0.0'), - fakeDsn, + dsn: fakeDsn, ); class MockRateLimiter implements RateLimiter {