diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt index f4715dfb4e..c49914470e 100644 --- a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt +++ b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt @@ -83,7 +83,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { "loadContexts" -> loadContexts(result) "displayRefreshRate" -> displayRefreshRate(result) "addReplayScreenshot" -> addReplayScreenshot(call.argument("path"), call.argument("timestamp"), result) - "sendReplayForEvent" -> sendReplayForEvent(call.argument("eventId"), call.argument("isCrash"), result) + "captureReplay" -> captureReplay(call.argument("isCrash"), result) else -> result.notImplemented() } } @@ -555,16 +555,15 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { result.success("") } - private fun sendReplayForEvent( - eventId: String?, + private fun captureReplay( isCrash: Boolean?, result: Result, ) { - if (eventId == null || isCrash == null) { + if (isCrash == null) { result.error("5", "Arguments are null", null) return } - replay.sendReplay(isCrash, eventId, null) + replay.captureReplay(isCrash) result.success(replay.getReplayId().toString()) } } diff --git a/flutter/lib/src/event_processor/replay_event_processor.dart b/flutter/lib/src/event_processor/replay_event_processor.dart index 4be68a4d00..1d534f94b0 100644 --- a/flutter/lib/src/event_processor/replay_event_processor.dart +++ b/flutter/lib/src/event_processor/replay_event_processor.dart @@ -15,7 +15,7 @@ class ReplayEventProcessor implements EventProcessor { event.exceptions?.isNotEmpty == true) { final isCrash = event.exceptions!.any((e) => e.mechanism?.handled == false); - await _binding.sendReplayForEvent(event.eventId, isCrash); + await _binding.captureReplay(isCrash); } return event; } diff --git a/flutter/lib/src/native/sentry_native_binding.dart b/flutter/lib/src/native/sentry_native_binding.dart index 15769c97d3..4fbbf1eea9 100644 --- a/flutter/lib/src/native/sentry_native_binding.dart +++ b/flutter/lib/src/native/sentry_native_binding.dart @@ -58,5 +58,5 @@ abstract class SentryNativeBinding { Future resumeAppHangTracking(); - Future sendReplayForEvent(SentryId eventId, bool isCrash); + Future captureReplay(bool isCrash); } diff --git a/flutter/lib/src/native/sentry_native_channel.dart b/flutter/lib/src/native/sentry_native_channel.dart index 20d0794f31..57e3fd198f 100644 --- a/flutter/lib/src/native/sentry_native_channel.dart +++ b/flutter/lib/src/native/sentry_native_channel.dart @@ -198,9 +198,8 @@ class SentryNativeChannel channel.invokeMethod('resumeAppHangTracking'); @override - Future sendReplayForEvent(SentryId eventId, bool isCrash) => - channel.invokeMethod('sendReplayForEvent', { - 'eventId': eventId.toString(), + Future captureReplay(bool isCrash) => + channel.invokeMethod('captureReplay', { 'isCrash': isCrash, }).then((value) => SentryId.fromId(value as String)); } diff --git a/flutter/test/mocks.mocks.dart b/flutter/test/mocks.mocks.dart index 3632555cc7..feb97b5927 100644 --- a/flutter/test/mocks.mocks.dart +++ b/flutter/test/mocks.mocks.dart @@ -1364,26 +1364,16 @@ class MockSentryNativeBinding extends _i1.Mock ) as _i7.Future); @override - _i7.Future<_i2.SentryId> sendReplayForEvent( - _i2.SentryId? eventId, - bool? isCrash, - ) => - (super.noSuchMethod( + _i7.Future<_i2.SentryId> captureReplay(bool? isCrash) => (super.noSuchMethod( Invocation.method( - #sendReplayForEvent, - [ - eventId, - isCrash, - ], + #captureReplay, + [isCrash], ), returnValue: _i7.Future<_i2.SentryId>.value(_FakeSentryId_5( this, Invocation.method( - #sendReplayForEvent, - [ - eventId, - isCrash, - ], + #captureReplay, + [isCrash], ), )), ) as _i7.Future<_i2.SentryId>);