Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refrain from overwriting the span status for unfinished spans #1481

Closed
Tracked by #128
marandaneto opened this issue May 25, 2023 · 1 comment
Closed
Tracked by #128

Refrain from overwriting the span status for unfinished spans #1481

marandaneto opened this issue May 25, 2023 · 1 comment

Comments

@marandaneto
Copy link
Contributor

Description

Context getsentry/team-mobile#128

@marandaneto
Copy link
Contributor Author

// finish unfinished spans otherwise transaction gets dropped
final spansToBeFinished = _children.where((span) => !span.finished);
for (final span in spansToBeFinished) {
await span.finish(
status: SpanStatus.deadlineExceeded(),
endTimestamp: commonEndTimestamp,
);
}
solution can be reverted since Relay does it internally now.
Check PR and see if there are more changes that need to be reverted.
Make sure that transactions get ingested after the changes and default values are applied by Relay correctly.
This should be based on v8 branch and add a note about older versions of Sentry self hosted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants