-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove polling for Enketo IDs #865
Comments
@lognaturel, how have things been going in terms of Backend being able to fetch Enketo IDs synchronously instead of async? If it's now rare that Enketo IDs are fetched async, I'd love to remove this polling from Frontend. |
Can you please remind me what action I was supposed to take? 🫣 It's my believe that Enketo's response has always been immediate and synchronous. Maybe I should verify in the Enketo source? |
Mostly I'm curious about what you've seen in practice. When you create a form or create a form draft or replace an existing form draft or publish a form draft, are the buttons in Frontend that link to Enketo enabled right away? I guess if Enketo's response is immediate, that should mean that the buttons in Frontend are enabled right away. I don't think you necessarily need to verify that in the source; mostly I'm interested in your observations in practice. (Assuming that enough time has passed since v2023.4 to make that determination.) I'm eager to remove the polling described above from Frontend, but first I want to confirm that it is useful only rarely if ever. |
I use all of the buttons mentioned all the time and have never seen them disabled since the 2023.4 changes! It has greatly, greatly improved my life. |
The most complicated part of the
FormShow
component is polling Backend for Enketo IDs for a form or form draft that's missing them. With getodk/central#385 in place, it should be the case that Backend returns Enketo IDs immediately in the vast majority of cases, making that polling much less useful. If that proves to be true in experience, I think we should strongly consider removing that polling from Frontend as a source of complexity that's outlived its usefulness. That polling is also noisy during local development if you don't have Enketo set up.EnketoPreview
andEnketoFill
already recommend refreshing, so I don't think any text would need to change:central-frontend/src/components/enketo/preview.vue
Line 57 in 972062f
central-frontend/src/components/enketo/fill.vue
Line 55 in 972062f
The text was updated successfully, but these errors were encountered: