Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity label from audit log #822

Closed
matthew-white opened this issue Apr 6, 2023 · 3 comments
Closed

Remove entity label from audit log #822

matthew-white opened this issue Apr 6, 2023 · 3 comments
Assignees
Labels
entities Multiple Encounter workflows

Comments

@matthew-white
Copy link
Member

matthew-white commented Apr 6, 2023

I don't think we need to make any changes right away, but as we start thinking about deleting and purging entities, I think we should think about what information about an entity should remain in the audit log even after the entity is deleted and purged. We should store the entity UUID and dataset name, but I think we should remove any entity data, including the entity label, because that information could be sensitive. Ideally, we don't log any of that information in the audit log to begin with.

We currently log the entity label as part of the details of the entity.create event. Frontend uses the entity label on the submission detail page, so if we remove it from the details of the audit log entry, we'll need to figure out how to get that information to Frontend.

Update from Kathleen:
Backend PR: #959
Frontend PR: getodk/central-frontend#850

@ktuite
Copy link
Member

ktuite commented Sep 1, 2023

How to test this issue:

For a submission that creates an entity, this event on the submission activity feed should look the same as before and have a working link

Image

Unless the entity has been deleted (soft-deleted with the API), in which case it should show the entity's UUID instead and not be a link (because the link wont go to a valid page).

@ktuite ktuite moved this from ✏️ in progress to ✅ done in ODK Central Sep 8, 2023
@dbemke
Copy link

dbemke commented Sep 11, 2023

Tested with success!

@srujner
Copy link

srujner commented Sep 11, 2023

Tested with success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Multiple Encounter workflows
Projects
Status: ✅ done
Development

No branches or pull requests

4 participants