Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More validation of entity property names #688

Closed
matthew-white opened this issue Nov 17, 2022 · 3 comments · Fixed by #845
Closed

More validation of entity property names #688

matthew-white opened this issue Nov 17, 2022 · 3 comments · Fixed by #845
Assignees
Labels
bug entities Multiple Encounter workflows

Comments

@matthew-white
Copy link
Member

matthew-white commented Nov 17, 2022

We need to do a little more validation of entity property names. pyxform also does that validation, so this issue is for after v2022.3.

What we do today:

  • A property cannot be named name or label.

(Not yet implemented:) We should also require that property names:

  • Be valid XML identifiers (start with letter or _, can only include letters, numbers, -, _, .)
  • Not start with __

This is similar to (the same as?) some of the validation that we do today for dataset names.

Notes for the QA team

pyxform has already been doing this validation for XLSForms. Now we are also doing this validation for XML XForms. It'd be good to verify that this validation happens when an XML XForm is uploaded.

@matthew-white matthew-white added bug entities Multiple Encounter workflows labels Nov 17, 2022
@lognaturel
Copy link
Member

This is similar to (the same as?)

Yes, but it's ok for property names to include periods (part of valid XML identifiers) but not dataset names (so it's easier to have .csv, .zip, etc exports)

@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Feb 15, 2023
@ktuite ktuite moved this from 🕒 backlog to ✏️ in progress in ODK Central Apr 24, 2023
@ktuite ktuite self-assigned this Apr 24, 2023
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central May 1, 2023
@srujner
Copy link

srujner commented May 17, 2023

Tested with Success!

1 similar comment
@dbemke
Copy link

dbemke commented May 17, 2023

Tested with Success!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug entities Multiple Encounter workflows
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

5 participants