diff --git a/app/serializers/v1/billable_metric_filter_serializer.rb b/app/serializers/v1/billable_metric_filter_serializer.rb index 08854c1ffbf..7b18970e6a3 100644 --- a/app/serializers/v1/billable_metric_filter_serializer.rb +++ b/app/serializers/v1/billable_metric_filter_serializer.rb @@ -4,7 +4,6 @@ module V1 class BillableMetricFilterSerializer < ModelSerializer def serialize { - lago_id: model.id, key: model.key, values: model.values.sort, } diff --git a/app/serializers/v1/charge_filter_serializer.rb b/app/serializers/v1/charge_filter_serializer.rb index b9a60e08bca..6deb9b31286 100644 --- a/app/serializers/v1/charge_filter_serializer.rb +++ b/app/serializers/v1/charge_filter_serializer.rb @@ -4,7 +4,6 @@ module V1 class ChargeFilterSerializer < ModelSerializer def serialize { - lago_id: model.id, invoice_display_name: model.invoice_display_name, properties: model.properties, values:, diff --git a/app/serializers/v1/customers/charge_usage_serializer.rb b/app/serializers/v1/customers/charge_usage_serializer.rb index d8431df8e5a..76b53fbfb55 100644 --- a/app/serializers/v1/customers/charge_usage_serializer.rb +++ b/app/serializers/v1/customers/charge_usage_serializer.rb @@ -52,7 +52,6 @@ def filters(fees) next unless f.charge_filter { - lago_id: f.charge_filter.id, units: f.units, amount_cents: f.amount_cents, events_count: f.events_count, diff --git a/app/services/payment_providers/stripe_service.rb b/app/services/payment_providers/stripe_service.rb index c5877b6edd6..cf2e3a1102d 100644 --- a/app/services/payment_providers/stripe_service.rb +++ b/app/services/payment_providers/stripe_service.rb @@ -201,6 +201,7 @@ def handle_event(organization:, event_json:) raise if event.livemode Rails.logger.warn("Stripe resource not found: #{e.message}. JSON: #{event_json}") + result end private diff --git a/spec/serializers/v1/billable_metric_filter_serializer_spec.rb b/spec/serializers/v1/billable_metric_filter_serializer_spec.rb index c9a3fbcdb60..bbc7901a7ae 100644 --- a/spec/serializers/v1/billable_metric_filter_serializer_spec.rb +++ b/spec/serializers/v1/billable_metric_filter_serializer_spec.rb @@ -11,7 +11,6 @@ it 'serializes the object' do aggregate_failures do expect(result['billable_metric_filter']).to include( - 'lago_id' => billable_metric_filter.id, 'key' => billable_metric_filter.key, 'values' => billable_metric_filter.values.sort, ) diff --git a/spec/serializers/v1/charge_filter_serializer_spec.rb b/spec/serializers/v1/charge_filter_serializer_spec.rb index 575f0a360ea..c3246a08bf3 100644 --- a/spec/serializers/v1/charge_filter_serializer_spec.rb +++ b/spec/serializers/v1/charge_filter_serializer_spec.rb @@ -23,7 +23,6 @@ result = JSON.parse(serializer.to_json) aggregate_failures do - expect(result['filter']['lago_id']).to eq(charge_filter.id) expect(result['filter']['invoice_display_name']).to eq(charge_filter.invoice_display_name) expect(result['filter']['properties']).to eq(charge_filter.properties) expect(result['filter']['values']).to eq( diff --git a/spec/serializers/v1/customers/charge_usage_serializer_spec.rb b/spec/serializers/v1/customers/charge_usage_serializer_spec.rb index 21b8b36b53b..3f80620c0b8 100644 --- a/spec/serializers/v1/customers/charge_usage_serializer_spec.rb +++ b/spec/serializers/v1/customers/charge_usage_serializer_spec.rb @@ -149,7 +149,6 @@ it 'returns filters array' do expect(result['charges'].first['filters'].first).to include( - 'lago_id' => charge_filter.id, 'units' => '10.0', 'amount_cents' => 100, 'events_count' => 12, @@ -158,7 +157,6 @@ ) expect(result['charges'].first['grouped_usage'].first['filters'].first).to include( - 'lago_id' => charge_filter.id, 'units' => '10.0', 'amount_cents' => 100, 'events_count' => 12,