Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go minimum version changed to 1.20 due to use of sync.Map#CompareAndSwap #836

Closed
lukestoward opened this issue Sep 5, 2023 · 0 comments · Fixed by #837
Closed

Go minimum version changed to 1.20 due to use of sync.Map#CompareAndSwap #836

lukestoward opened this issue Sep 5, 2023 · 0 comments · Fixed by #837

Comments

@lukestoward
Copy link

lukestoward commented Sep 5, 2023

I noticed recently due to issues compiling that 0.119.0 changed the minimum version of Go required to use this module from 1.18 (as stated in the go.mod to 1.20. This is due to an added usage of the sync.Map#CompareAndSwap method, which was added to the standard library in Go 1.20.

Looking through the changes, I believe this line is the cause. Please can you update the go.mod to state the minimum Go version is 1.20 or enable the code to be compiled with 1.18 again.

@lukestoward lukestoward changed the title Go minimum version 1.20 due to use of sync.Map#CompareAndSwap Go minimum version changed to 1.20 due to use of sync.Map#CompareAndSwap Sep 5, 2023
@fenollp fenollp linked a pull request Sep 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant