Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw language strings displayed when theme is not the active theme #2140

Closed
paulhibbitts opened this issue May 5, 2021 · 2 comments
Closed
Assignees

Comments

@paulhibbitts
Copy link
Contributor

I just updated to the latest Typhoon release, and noticed that if the Active Theme is not Typhoon (mine was set to Quark) raw language strings are shown in the Typhoon settings page. However, if Typhoon is made the Active Theme then language strings are shown as expected.

Below is what I see when Typhoon is not the Active Theme:

2021-05-05_07-18-10

If any more info etc. is helpful please let me know.

Thanks very much,
Paul

@rhukster
Copy link
Member

rhukster commented May 5, 2021

This is actually a known issue of Grav admin plugin, and not Typhoon. If not active, it's similar to a plugin being disabled. Basically languages are not loaded. Also any custom fields are not loaded, so I think the best option is to not show config unless enabled/activated.

@rhukster rhukster transferred this issue from getgrav/grav-premium-issues May 5, 2021
@rhukster rhukster changed the title [Typhoon] raw language strings displayed when Typhoon is not Active Theme Raw language strings displayed when theme is not the active theme May 5, 2021
@rhukster rhukster self-assigned this May 5, 2021
@omega8cc
Copy link

We can see the same problem affecting sites which skipped many releases and were recently upgraded to latest Grav release. However, in these sites admin literally everything is looking like that, including all admin menus and buttons. We have checked site settings etc and everything looks fine, yet, the default (en) language is simply not loaded in the admin panel at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants