Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page dialogue closes unexpectedly when trying to change Page Template #2089

Closed
amadeusp opened this issue Mar 3, 2021 · 3 comments
Closed
Assignees

Comments

@amadeusp
Copy link

amadeusp commented Mar 3, 2021

Problem:
When creating a new page in Grav Admin and trying to select a custom page template, the Add Page dialogue closes unexpectedly. It is therefore not possible to create a new page with a custom page template via the Add Page dialogue. In fact it is possible, but only when opening the Add Page dialogue for a second time.

System configuration:

  • Apache 2.4.46
  • PHP 8.0.1
  • Grav v1.7.7
  • Admin Panel v1.10.6
  • Custom page template in custom theme
  • Firefox 86.0 (64-bit)

Steps:

  1. Go to project.tld/admin and authenticate
  2. Go to Pages
  3. Click on Add Page
  4. In the dialogue set a Page Title
  5. In the dialogue try to select your custom template

Observations:

  • First, this only happens in Firefox for me. Chrome or Safari do not show the same behavior.
  • The Add Page dialogue only closes when the item you are trying to select in the Page Template select is outside of the actual Add Page dialogue (meaning, the Page Template select itself reaches out of the Add Page dialogue).
@w00fz w00fz self-assigned this Mar 3, 2021
@w00fz
Copy link
Member

w00fz commented Mar 3, 2021

this has been also reported with #2065 , although was fixed in #1682 .

not sure how this is an issue again, needs investigating.

@mahagr
Copy link
Member

mahagr commented Mar 4, 2021

I can confirm the issue.

@w00fz w00fz transferred this issue from getgrav/grav Mar 4, 2021
@w00fz w00fz closed this as completed in 43f16f6 Mar 18, 2021
@w00fz
Copy link
Member

w00fz commented Mar 18, 2021

Since I grew tired of fixing this issue every mont, from now on it won't be possible to click on the overlay and accidentally trigger the close action of the modal. This includes selecting an item outside of the modal boundaries from the dropdown which was the main problem.
There is now a Cancel button that can be clicked for closing the modal or the Escape key which is stil available as an option.

w00fz-2021-03-18_@_16 09 43@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants