Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creator tool instance list sorting by label as opposed to class name #508

Closed
BigRoy opened this issue Jan 9, 2020 · 0 comments · Fixed by #530
Closed

Creator tool instance list sorting by label as opposed to class name #508

BigRoy opened this issue Jan 9, 2020 · 0 comments · Fixed by #530

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Jan 9, 2020

Issue

It seems currently the Plug-ins in the Creator tool are sorted by the class name, however that looks fairly odd in the Creator tool when they are labeled differently.

class Plugin1(api.Creator):
    label = "D"
    family = "D"

class Plugin2(api.Creator):
    label = "B"
    family = "B"

class Plugin3(api.Creator):
    label = "A"
    family = "A"

class Plugin4(api.Creator):
    label = "C"
    family = "C"

In the creator tool these would currently sort by the class name, making it:

D
B
A
C

They are sorted like this by api.discover in Creator tool which sorts by class name here.

I believe visually it would make more sense to sort the list by visual name in the UI, which would be the label when defined.

Is there a reason to be against sorting by the label and preserve current behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant