Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5292: replace brokenUrlPlaceholder with a local, tranparent one #5910

Merged
merged 1 commit into from
Sep 22, 2020
Merged

#5292: replace brokenUrlPlaceholder with a local, tranparent one #5910

merged 1 commit into from
Sep 22, 2020

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Sep 22, 2020 •
edited by tdipisa
Loading

Description

This PR solves a part of the issue #5292 setting brokenUrlPlaceholder to a (local)
Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#5292

What is the new behavior?
The WMTS part of #5292 should be mitigated. The broken URLs responses now are transparent. Maybe this solves also some slow down problems due to servers that can not reach that URL ?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added this to the 2020.02.02 milestone Sep 22, 2020
@offtherailz offtherailz requested a review from mbarto September 22, 2020 08:28
@offtherailz offtherailz self-assigned this Sep 22, 2020
@offtherailz offtherailz mentioned this pull request Sep 22, 2020
Closed
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 22, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 83.258% when pulling b5aa86d on offtherailz:5292_1 into d39414d on geosolutions-it:master.

@offtherailz offtherailz merged commit 5aff44b into geosolutions-it:master Sep 22, 2020
@offtherailz
Copy link
Member Author

Need to backport for 2020.02.xx

offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Sep 22, 2020
@offtherailz
geosolutions-it#5292: replace brokenUrlPlaceholder with a local, tran…
9f94020 
…parent one (geosolutions-it#5910)
@offtherailz offtherailz mentioned this pull request Sep 22, 2020
Merged
offtherailz added a commit that referenced this pull request Sep 23, 2020
@offtherailz
#5292: replace brokenUrlPlaceholder with a local, tranparent one (#5910…
0e5bb31 
…) (#5913)
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto approved these changes

Assignees

@offtherailz offtherailz

Labels
geOrchestra Priority: High
Projects
None yet
Milestone
2020.02.02
Development

Successfully merging this pull request may close these issues.
5 participants
@offtherailz @coveralls @mbarto @tdipisa @ElenaGallo