Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C125-144: Print background layer for WMTS and TileProvider #5189

Closed
wants to merge 3 commits into from

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Apr 29, 2020

Description

Mapfish print specification for WMTS and TileProviders layers

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

https://github.com/geosolutions-it/austrocontrol-C125/issues/144

What is the current behavior?
No print specification available for WMTS and TileProvider

What is the new behavior?
Print specification for WMTS and TileProvider available which enables printing of those layers

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

WMTS Layer: Although this is printable the base layer background is displayed in white, which needs to be investigated as it might be a problem with plugin or service
(Ref: https://github.com/geosolutions-it/austrocontrol-C125/issues/144#issuecomment-620455864)

TMS Layer: This PR doesn't add print specification for TMS due to an issue with tile display
(Ref: https://github.com/geosolutions-it/austrocontrol-C125/issues/144#issuecomment-621055104)

@dsuren1 dsuren1 requested a review from offtherailz April 29, 2020 14:24
@dsuren1 dsuren1 self-assigned this Apr 29, 2020
@coveralls
Copy link

coveralls commented Apr 29, 2020

Coverage Status

Coverage increased (+0.008%) to 83.554% when pulling b8f058a on dsuren1:C125-144 into a03c913 on geosolutions-it:master.

# Conflicts:
#	web/client/utils/PrintUtils.js
@offtherailz
Copy link
Member

Blocked because of #5292

@tdipisa tdipisa added Priority: High BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed Priority: Medium labels May 21, 2020
@tdipisa tdipisa modified the milestones: 2020.02.00, 2020.02.01 May 29, 2020
@tdipisa tdipisa modified the milestones: 2020.02.01, 2020.02.02, 2020.03.00 Jul 15, 2020
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 16, 2020
@tdipisa tdipisa removed the Blocked label Sep 24, 2020
@tdipisa tdipisa modified the milestones: 2020.03.00, 2020.02.02 Sep 24, 2020
@tdipisa tdipisa added geOrchestra BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Priority: Blocker and removed Priority: High labels Sep 24, 2020
@offtherailz
Copy link
Member

Closing in favor of
#5953

@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants