Fix #10835 fix load map error #10842
Closed
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
allyoucanmap
requested changes
Feb 21, 2025
| @@ -302,8 +302,7 @@ class OpenlayersMap extends React.Component { | |||
| this.map.updateSize(); | |||
| }, 0); | |||
| } | |||
| const centerIsUpdated = this.isNearlyEqual(newProps.center.y, this.props.center.y) && | |||
| this.isNearlyEqual(newProps.center.x, this.props.center.x); | |||
| const centerIsUpdated = !isEqual(newProps.center, this.props.center); | |||
There was a problem hiding this comment.
I did additional test locally, with this fix seems to work but as soon as I move the map there is a tile reload
tile-reload.mp4
tested also with:
const centerIsUpdated = newProps.center !== this.props.center;
but it seems the same
I think for the moment is better to revert the commit
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with this implementation the map does not go in loop
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10835
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information