-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10785 Review of footer plugin #10822
Merged
allyoucanmap
merged 5 commits into
geosolutions-it:master
from
allyoucanmap:issue_10785
Feb 25, 2025
Merged
Fix #10785 Review of footer plugin #10822
allyoucanmap
merged 5 commits into
geosolutions-it:master
from
allyoucanmap:issue_10785
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
offtherailz
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only 2 notes:
- Map now contains 2 footers (mobile none). Not sure if it make sense to have a footer fixed on map view only for 3 items (maybe less), like about etc...
- I see there is the possibility to keep an html footer. It will be still sticked to the bottom of the browser ? Some client may need long footer notes. In this case how we can manage them
You can clarify these things at project level and merge after that.
…into issue_10785
@allyoucanmap please remove the new footer from resource pages only for now (maintain it on admin pages). Let's maintain it fixed as you are proposing. |
offtherailz
reviewed
Feb 25, 2025
offtherailz
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to the footer plugin:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10785
What is the new behavior?
Refactor of the footer plugin including it in all pages
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information