Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10785 Review of footer plugin #10822

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR introduces changes to the footer plugin:

  • reviewed configuration
  • included support for a fixed menu at the bottom of the page
  • the footer plugin has been included in all pages including viewer (only the menu items will be visible)
  • removed old Footer plugin to avoid confusion
  • refactor the menu component removing unused props and logic
  • show about, documentation and github links in the footer plugin

image

image

image

image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#10785

What is the new behavior?

Refactor of the footer plugin including it in all pages

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes

Other useful information

@allyoucanmap allyoucanmap added this to the 2025.01.00 milestone Feb 19, 2025
@allyoucanmap allyoucanmap self-assigned this Feb 19, 2025
@allyoucanmap allyoucanmap linked an issue Feb 19, 2025 that may be closed by this pull request
1 task
@tdipisa tdipisa requested a review from offtherailz February 19, 2025 10:59
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 2 notes:

  • Map now contains 2 footers (mobile none). Not sure if it make sense to have a footer fixed on map view only for 3 items (maybe less), like about etc...
  • I see there is the possibility to keep an html footer. It will be still sticked to the bottom of the browser ? Some client may need long footer notes. In this case how we can manage them
    You can clarify these things at project level and merge after that.

@tdipisa
Copy link
Member

tdipisa commented Feb 24, 2025

@allyoucanmap please remove the new footer from resource pages only for now (maintain it on admin pages). Let's maintain it fixed as you are proposing.

@tdipisa tdipisa requested a review from offtherailz February 24, 2025 16:45
@allyoucanmap allyoucanmap merged commit 866ad30 into geosolutions-it:master Feb 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review of footer plugin
3 participants