Fix #10807 updating view also when center prop is changing #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
306
to
307
| if (this.map && ((this.props.projection !== newProps.projection) || (this.props.center !== newProps.center) || this.haveResolutionsChanged(newProps)) || this.haveRotationChanged(newProps) || this.props.limits !== newProps.limits) { | ||
| if (this.props.projection !== newProps.projection || (this.props.center !== newProps.center) || this.props.limits !== newProps.limits || this.haveRotationChanged(newProps)) { |
There was a problem hiding this comment.
In this PR #10525 was introduced the isNearlyEqual to avoid exact comparation of the center. Shouldn't we use the same approach here?
There was a problem hiding this comment.
sounds good I guess. i'll update PR
allyoucanmap
approved these changes
Feb 20, 2025
|
@ElenaGallo please test this fix on dev, thanks |
Closed
1 task
MV88
added a commit
to MV88/MapStore2
that referenced
this pull request
Feb 21, 2025
… is changing (geosolutions-it#10808)" This reverts commit 3fedb7f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now maps correctly center the view when loading a shared link
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10807
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information