Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates for mapstore-services and POMs refactoring #10015

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Dependency updates for mapstore-services and POMs refactoring #10015

merged 10 commits into from
Mar 5, 2024

Conversation

tdipisa
Copy link
Member

@tdipisa tdipisa commented Mar 5, 2024 •
edited
Loading

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa requested a review from offtherailz March 5, 2024 08:58
@tdipisa tdipisa added this to the 2024.01.00 milestone Mar 5, 2024
@tdipisa tdipisa added Internal dependencies Pull requests that update a dependency file labels Mar 5, 2024
@tdipisa tdipisa removed their assignment Mar 5, 2024
tdipisa
tdipisa commented Mar 5, 2024
View reviewed changes
Copy link
Member Author

@tdipisa tdipisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afabiani we have opened this PR to contribute what you have done for c125-2024.01.xx branch in master. Some conflicts have been fixed as well.

Can you please double check the PR? Can you also please explain better the purpose of this contribution?
There are many failing checks.

@afabiani
Copy link
Member

afabiani commented Mar 5, 2024

@tdipisa the purpose was to cleanup the poms mess and update the dependencies. Main goal was to avoid spreading and duplicating the properties around and have the dependencies coherent among the modules. Unfortunately the conflicts resolution was not good here you it has broken all the poms inheritance. I will send a fix for that.

afabiani added 3 commits March 5, 2024 11:18
@afabiani
- Fix maven poms
afe5e1b
@afabiani
Merge branch 'master' into c125-2024.01.xx
84de437
@afabiani
Bump version of GeoStore to 2.2-SNAPSHOT
d44db80 
Bump version of print-lib to 2.4-SNAPSHOT
Bump version of http_proxy to 1.6-SNAPSHOT
@afabiani
Copy link
Member

afabiani commented Mar 5, 2024

Done

@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C125-2020-AUSTROCONTROL-Map2Imp and removed Internal labels Mar 5, 2024
@tdipisa
Copy link
Member Author

tdipisa commented Mar 5, 2024 •
edited
Loading

@offtherailz this PR should be backported to 2024.01.xx but using versions (of geostore, proxy, services and print) expected for the stable branch.

The backport should be done only after functional tests. Other backports are necessary:

geosolutions-it/geostore#340 (comment)

@tdipisa tdipisa mentioned this pull request Mar 5, 2024
Merged
@tdipisa tdipisa linked an issue Mar 5, 2024 that may be closed by this pull request
Release 2024.01.00 #10012
Closed
64 tasks
@tdipisa tdipisa mentioned this pull request Mar 5, 2024
Closed
6 tasks
@tdipisa tdipisa changed the title Dependency updates for mapstore-services Dependency updates for mapstore-services and POMs refactoring Mar 5, 2024
offtherailz
offtherailz reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to apply my changes and test.

offtherailz
offtherailz approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have fixed all the workflows on github to work with your changes. Hope this could simplify updates and a lot of troubles in our future work. 🤯

@offtherailz offtherailz merged commit 35e1073 into master Mar 5, 2024
10 checks passed
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Mar 21, 2024
@tdipisa @offtherailz
Dependency updates for mapstore-services and POMs refactoring (geosol…
b04102c 
…utions-it#10015)
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Mar 21, 2024
@tdipisa @offtherailz
Dependency updates for mapstore-services and POMs refactoring (geosol…
ca1d2ef 
…utions-it#10015)
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Mar 21, 2024
@tdipisa @offtherailz
Dependency updates for mapstore-services and POMs refactoring (geosol…
30631c1 
…utions-it#10015)
@offtherailz offtherailz mentioned this pull request Mar 21, 2024
Merged
offtherailz added a commit that referenced this pull request Mar 22, 2024
@offtherailz
[Backport 2024.01.xx] Dependency updates for mapstore-services and PO…
7c505d9 
…Ms refactoring (#10015) (#10105)
@offtherailz offtherailz linked an issue Mar 29, 2024 that may be closed by this pull request
Update GHA due to latest pom changes #10020
Closed
6 tasks
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 29, 2024
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
@tdipisa @offtherailz
Dependency updates for mapstore-services and POMs refactoring (geosol…
f0527f2 
…utions-it#10015)
@tdipisa tdipisa mentioned this pull request Jun 3, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@afabiani afabiani

Labels
C125-AUSTROCONTROL-2024-MapStore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

Update GHA due to latest pom changes Release 2024.01.00
4 participants
@tdipisa @afabiani @offtherailz @ElenaGallo