Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Context Plugins #4774

Closed
2 tasks
tdipisa opened this issue Jan 22, 2020 · 4 comments
Closed
2 tasks

Application Context Plugins #4774

tdipisa opened this issue Jan 22, 2020 · 4 comments
Assignees
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Jan 22, 2020

Description

Adds the ability to add and configure plugins in application contexts

Acceptance criteria

Other useful information

@tdipisa tdipisa added the New Feature used for new functionalities label Jan 22, 2020
@tdipisa tdipisa added this to the 2020.02.00 milestone Jan 22, 2020
@francoxyz
Copy link
Contributor

francoxyz commented Jan 22, 2020

@vlt1 @tdipisa @offtherailz The following issues were noticed in plugins configuration:

    • It is possible to insert the plugin Map Details that allows to see map details but it is actually impossible to add details for contexts. If we don't want to improve application contexts adding details to them, we should remove the possibility to add this plugin
      --> **Reply by @offtherailz **: Now is not possible, but in future we will be able to open maps in context, therefore this is possible. You can do it, for the moment, in the URL, putting the map id in the URL. example.
    • The Query panel plugin should probably be hidden from plugin list, and should be enabled by default when others plugins that use the Query panel are added (like Attribute Table, layer filter, Widgets). There's probably a problem related to Query panel plugin because sometimes it enables adding the List of Layers plugin and sometimes does not). Moreover I can add this plugin alone also if it depends from other plugins.
      --> @offtherailz: Sure, It is listed because it is configurable.
    • Style Editor plugin what is it for? Seems that nothing change adding or not this plugin (if this plugin serves to create new styles it doesn't work). Moreover this plugin can be added alone, also if it probably depends from TOC and from layer settings
    • Widgets plugin should depends from List of Layers plugin, but I can actually add it alone. If you add both Widgets plugin and List of Layers plugin, the widgets button is not present in toc selecting a layer
    • The Download data from attribute table plugin can be added alone, but should be related to Attribute Table plugin

Morover was noticed that in step 3 of the wizard (Configure Map), clicking on Reload Map button, the modal window that opens is draggable vertically (why?) and the X button is in lowercase. If I click outside the window, it closes.

*By @offtherailz *: I added some notes under these points(Work In Progress)

@tdipisa
Copy link
Member Author

tdipisa commented Jan 28, 2020

In addition I found the following to take into account (I tested in geOrchestra DEV):

  • The show metadata option should be disabled by default, so the related button in TOC toolbar does not appears (the button is automatically enabled when you ad a layer from a CSW source)

  • If I add undo/redo plugins nothing appears in the viewer: buttons are not present in nav toolbar. Only adding the expander plugin these are available. We should at least set up a dependency in configuration and make the expander plugin hidden to be automatically added when needed.

  • The AutoMapUpdate plugin can be excluded from the list I think

  • If I add just one plugin related to the MS nav toolbar (i.e. zoom to the max extent) when I click on the map the toolbar move on the left

image

  • I think the home button plugin can be excluded from the georchestra configuration

  • If I embed a context in an Iframe the geOrchestra header must not appear.

  • after creating a context without the Identify plugin enabled, if I click on the map the marker appears: it should appears only if the identify tool has been activated for that context.

  • If I add the TOC with the attribute table enabled, the attribute table is not available in the viewer's context. The same for Layer Settings.

  • When I add the 'About plugin' also the Burger menu is automatically added but finally the about is not present in the context

image

@francoxyz
Copy link
Contributor

Some additional points below:

  • In "Version" plugin the description is "Show Mapstore Version in settings window" but in Georchestra the version showed is the Georchestra one

  • Adding Map Templates, Burger Menu is not added together

  • Adding "Save" plugin, the Burger Menu is added together but after the save option is not present in the Menu

  • Adding "Save as" plugin, the Burger Menu is added together but after the save as option is not present in the Menu

@tdipisa
Copy link
Member Author

tdipisa commented Jan 29, 2020

Closed in favor of georchestra/mapstore2-georchestra#155.

@tdipisa tdipisa closed this as completed Jan 29, 2020
@tdipisa tdipisa self-assigned this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants