Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for exteneded signing keys in runGYTxMonadIO #394

Closed
euonymos opened this issue Jan 14, 2025 · 3 comments · Fixed by #397
Closed

Support for exteneded signing keys in runGYTxMonadIO #394

euonymos opened this issue Jan 14, 2025 · 3 comments · Fixed by #397

Comments

@euonymos
Copy link
Contributor

Currently runGYTxMonadIO can't be used with extended keys.

I believe runGYTxMonadIO should use ToShelleyWitnessSigningKey type class instead of GYPaymentSigningKey argument.

Workaround: supply a dummy key to runGYTxMonadIO, use signGYTxBody which accept any keys.

@mikekeke
Copy link

I'm currently doing some tx building CLI for the project I'm working on using Atlas, and need to use wallet that I know seed phrase for. Having runGYTxMonadIO or something alike that accepts extended keys would be really handy.

@sourabhxyz
Copy link
Member

Thanks for sharing your use case @mikekeke! We do something similar in our dex-contracts-api repository where we first load key from seed phrase (here) and then use it later to sign for tx, here. I am wondering if you could do something similar.

Also, the PR by Ilia related to this improvement should be merged today.

@mikekeke
Copy link

@sourabhxyz Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants