From ed0cc7b482e51245752aa0ab03d3bb4b68a240a3 Mon Sep 17 00:00:00 2001 From: DudaGod Date: Thu, 22 Mar 2018 19:16:30 +0300 Subject: [PATCH] fix(gemini-test-adapter): method hasDiff should return false for error --- lib/test-adapter/gemini-test-adapter.js | 2 +- test/lib/test-adapter/gemini-test-adapter.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/test-adapter/gemini-test-adapter.js b/lib/test-adapter/gemini-test-adapter.js index 83c73f6b2..c3f25aae6 100644 --- a/lib/test-adapter/gemini-test-adapter.js +++ b/lib/test-adapter/gemini-test-adapter.js @@ -17,7 +17,7 @@ module.exports = class GeminiTestResultAdapter extends TestAdapter { } hasDiff() { - return !this._testResult.equal; + return this._testResult.hasOwnProperty('equal') && !this._testResult.equal; } get error() { diff --git a/test/lib/test-adapter/gemini-test-adapter.js b/test/lib/test-adapter/gemini-test-adapter.js index acfe36c22..5845b0830 100644 --- a/test/lib/test-adapter/gemini-test-adapter.js +++ b/test/lib/test-adapter/gemini-test-adapter.js @@ -22,14 +22,14 @@ describe('gemini test adapter', () => { assert.isFalse(geminiTestAdapter.hasDiff()); }); - it('should return "true" if test failed', () => { - const geminiTestAdapter = new GeminiTestResultAdapter({equal: false}); + it('should return "false" if test errored (does not have image comparison result)', () => { + const geminiTestAdapter = new GeminiTestResultAdapter({}); - assert.isTrue(geminiTestAdapter.hasDiff()); + assert.isFalse(geminiTestAdapter.hasDiff()); }); - it('should return "true" if test errored (does not have image comparison result)', () => { - const geminiTestAdapter = new GeminiTestResultAdapter({}); + it('should return "true" if test failed', () => { + const geminiTestAdapter = new GeminiTestResultAdapter({equal: false}); assert.isTrue(geminiTestAdapter.hasDiff()); });