fix(gemini-test-adapter): method hasDiff should return false for error

gemini-testing · Mar 22, 2018 · ed0cc7b · ed0cc7b
1 parent 5306c37
commit ed0cc7b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/test-adapter/gemini-test-adapter.js b/lib/test-adapter/gemini-test-adapter.js
@@ -17,7 +17,7 @@ module.exports = class GeminiTestResultAdapter extends TestAdapter {
     }
 
     hasDiff() {
-        return !this._testResult.equal;
+        return this._testResult.hasOwnProperty('equal') && !this._testResult.equal;
     }
 
     get error() {

diff --git a/test/lib/test-adapter/gemini-test-adapter.js b/test/lib/test-adapter/gemini-test-adapter.js
@@ -22,14 +22,14 @@ describe('gemini test adapter', () => {
             assert.isFalse(geminiTestAdapter.hasDiff());
         });
 
-        it('should return "true" if test failed', () => {
-            const geminiTestAdapter = new GeminiTestResultAdapter({equal: false});
+        it('should return "false" if test errored (does not have image comparison result)', () => {
+            const geminiTestAdapter = new GeminiTestResultAdapter({});
 
-            assert.isTrue(geminiTestAdapter.hasDiff());
+            assert.isFalse(geminiTestAdapter.hasDiff());
         });
 
-        it('should return "true" if test errored (does not have image comparison result)', () => {
-            const geminiTestAdapter = new GeminiTestResultAdapter({});
+        it('should return "true" if test failed', () => {
+            const geminiTestAdapter = new GeminiTestResultAdapter({equal: false});
 
             assert.isTrue(geminiTestAdapter.hasDiff());
         });