Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] remove-placeholder with top-country breaks the selection of country in country-select #58

Open
kjesien opened this issue Jun 11, 2021 · 0 comments

Comments

@kjesien
Copy link

kjesien commented Jun 11, 2021

Having remove-placeholder with top-country like this:

<country-select
  v-model="country"
  :country="country"
  top-country="US"
  remove-placeholder
/>

breaks the ability to change the selection.
Calling onChange in countries computed property in line 69 causes constant re-selection of top-country.

BTW - computed properties should not have such side effects like emission of events.

@kjesien kjesien changed the title [BUG] remove-placeholder breaks the selection of country in country-select [BUG] remove-placeholder with top-country breaks the selection of country in country-select Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant