Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeLog is outdated #128

Open
p-alik opened this issue Jun 30, 2017 · 2 comments
Open

ChangeLog is outdated #128

p-alik opened this issue Jun 30, 2017 · 2 comments

Comments

@p-alik
Copy link
Collaborator

p-alik commented Jun 30, 2017

no updates since "1.1.12 Sun Feb 9 04:27:38 PST 2014"

@esabol
Copy link
Member

esabol commented Jul 19, 2017

I think @SpamapS killed it in favor of git log, but I prefer reading a more curated list of changes whenever I approach a new package of software, so I'd like to see the ChangeLog updated and maintained. Just my two cents....

@SpamapS
Copy link
Member

SpamapS commented Jul 19, 2017

So, I agree that a curated changelog is nice to have. However, I haven't had the time to make one with every release.

Note that I did do one for v1.1.16 in the tag annotation:

$ git show 1.1.16
tag 1.1.16
Tagger: Clint Byrum <clint@fewbar.com>
Date:   Tue May 23 09:35:01 2017 -0700

Bugfix release including:
- Fixes to HTTP protocol plugin and background jobs
- Redis queue plugin refactored
- TCP Keepalive settings are properly respected
- Various fixes for stricter C++11 compilation
- Changed from CYaSSL to WolfSSL
- Various fixes to memcached queue plugin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAABCAAGBQJZJGaDAAoJEFOMB2b0vLOO2lYIAK+cOq0g8holkIpvY1Wj2Rca
ywV4Ey6dmO4GOUYV+ZqqwUJTqw0B4RzozEJcOMMftD385/xxYJKLcPl1i/l919DL
BLK7EfUcBoOWmi1qGIssZP55U3FJsb3qt8IfMu9Yh9MV1I2Cfefm9uO0M6enrl6t
2qFukOjTJhYW9fTzg4R7dCNtpAa/xYLmXM76ChnYCktVm9rr7n/kt2lUgVenGhF9
umgpphYTix/aInRnGF8alTWdCJMlinQuq9vMSNnJfZeCH8/jhGb/qIJZK7GRSrlf
oULKwGxniVXPaleAKpqEdxb+Ipx5yEd/ACJLjPdBlvI+8GwmOJjHGxCF+6HjA8I=
=2X/t
-----END PGP SIGNATURE-----

commit e3dbdda3dab290790c10cd6be815c45cb2dd3054
Merge: 4ee46f8 c906a12
Author: bonnyci[bot] <bonnyci[bot]@users.noreply.github.com>
Date:   Thu May 18 18:44:32 2017 +0000

    Merge pull request #104 from p-alik/http-plugin
    
    gearmand should release http client if request contains 'X-Gearman-Background: true' header
    
    Reviewed-by: https://github.com/bonnyci[bot]

We could make that a regular thing. But putting it in git as a file makes very little sense since git's entire purpose in life is literally to document changes.

Also, note that 'make dist' puts a git based changelog in every tarball. It's not pretty, but it is automated.

$ head -100 ChangeLog 

HEAD -> upstream_master, tag: 1.1.15, upstream/master - 2017-02-17 Fix
comparison of pointer and bool
 - 2016-12-26 Fix specfile for renamed README
 - 2016-12-26 Update readme md (#66)
 - 2016-12-14 remove gearmand text command shutdown (#40)

kris-lab-priority-status - 2016-12-14 Fixed typo (jon_queued ->
job_queued)
 - 2016-12-14 Added "prioritystatus" command to display queued jobs
 broken down by priority.

origin/master, origin/HEAD, master - 2016-12-03 Turn on artifact storage

automate-travis - 2016-11-27 Use _exit() in fork test to fix race (#47)

chenzi2015-master - 2016-11-18 add "redis-password" option to redis
 - 2016-11-22 bug fixing:  instead of undefined
 - 2016-11-22 bsd portable shebang
 - 2016-11-19 Ignore tarballs built as a result of 'make dist'

tag: 1.1.14, upstream/upstream_master - 2016-11-16 Fix typos found by
Debian lintian
 - 2016-11-03 Do not exceed 80 chars per line
 - 2016-11-03 Redis queue: take server address into account
 - 2016-11-03 redis queue: improve debugging
 - 2016-10-19 Travis: ensure redis support is built and tested
 - 2016-10-18 redis queue: fix loading old jobs from the database
 - 2016-10-14 bug fixing: http response with empty content
 - 2016-10-12 Include docs in dist tarball
 - 2016-09-22 travis build matrix with different compilers
 - 2016-09-23 replace launchpad urls by github [ci skip]
 - 2016-09-25 Generate ChangeLog in make dist
 - 2016-09-24 Use git describe to determine version
 - 2016-07-06 bug fixing: http response an empty content on post
 request. (lp rev 910)
 - 2016-07-02 bug fix endless loop on http bad request or bad method
 (lp rev802)
 - 2016-07-03 Add documentation for the purpose of Unique ID
 - 2016-07-03 Add basic documentation of undocumented protocol
 - 2016-07-03 Fix "make install"
 - 2016-07-03 Fix typo in protocol docs
 - 2016-06-30 Move build-aux higher in configure.ac
 - 2016-06-30 Add docs/build to .gitignore
 - 2016-06-30 Add files bzr automatically ignores to .gitignore
 - 2016-06-30 Change build to use git instead of bzr
 - 2016-06-30 Change bzr to git in HACKING/README
 - 2016-06-29 add travis build badge [ci skip]
 - 2016-06-29 Add Travis CI integration
 - 2016-06-29 Create README.md
 - 2016-06-29 renamed:    .bzrignore -> .gitignore
 - 2014-02-15 Fix for NOTPARALLEL issue on building docs.
 - 2014-02-12 Merge bzr://10.0.3.21/ Build: jenkins-Gearmand-1026
 - 2014-02-12 Fix make man to not slow down main build.
 - 2014-02-12 Fix for constant recompile issue.
 - 2014-02-11 Simplify how we grab artifact.
 - 2014-02-10 Fix bad macro.
 - 2014-02-10 Remove dead rpm.am file.
 - 2014-02-10 Merge bzr://gaz.haus/ Build: jenkins-Gearmand-1011

So, I guess what I'm saying is, make good commit messages, and we won't have to worry about curating after the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants