make failures with 1.1.16 on CentOS 6 #113
Comments
|
could you provide some |
|
@p-alik gcc infomation best regards~ |
|
Is there any chance you update |
|
Indeed, we updated 1.1.16 to be a bit more modern in our C++. It's possible 4.8.0 was broken for new stuff. |
|
I update my gcc to version 4.8.5, make still failures with infomation: gcc --version: uname -a: |
|
Build on CentOS 6.5 without hiredis support in Vagrant Box doen't fail. I couldn't install hiredis because |
|
Same issue with GCC 4.4.7 on Centos 6 |
|
So, I think we can go ahead and confirm, with the 1.1.16 release, hiredis support is broken on CentOS 6. I don't know if I'll have time to fix this. I also don't know if I want to do much to focus on it unless we find a way to test automatically with that release of gcc. If somebody wants to look into how that might work on Travis CI, that would be great. I run BonnyCI, and I do know how to make it test CentOS 6, but it's a side-project now, so I'm not sure I want to rely on it. I'd also be perfectly happy to integrate checks into our system from a Jenkins running somewhere that would build/test on platforms users care about. So for now, this is broken. Patches wanted! |
|
(Oh I also confirmed that it's broken on CentOS 6 with 4.4.7 and hiredis master, FYI) |
|
I modify the file const size_t argvlen[6] = {
(const size_t)5,
(const size_t)key.size(),
(const size_t)4,
(const size_t)data_size,
(const size_t)8,
_priority.size(),
};make pass ~ I don't known much about c++, just a test :) |
|
I would recommend that you test changing line 87 of queue.cc from to |
|
@esabol it works ! thx 👍 |
|
Can somebody please test master on CentOS 6? If it works I'll close this and make a quick 1.1.17 release. |
|
My attempt to build in vagrant virtual box failed. |
|
I've never been able to bootstrap on RHEL/CentOS 6.x. The autoconf stuff is too old or something. You can still compile and use it if you bootstrap on another OS though, so the release tarballs have compiled fine for me on CentOS 6.x, for example. I think I've bootstrapped on RHEL/CentOS 7.3 and then compiled on 6.4 on occasion. What I would recommend is that you download the 1.1.16 release tarball and patch that one line and compile on CentOS 6. I'd try it myself, but I don't have Hiredis or Redis installed. |
|
Does not work for me. Now I get this: |
|
Me too on CentOS 6 |
|
Please reopen. This issue is NOT resolved. |
|
It'd be pleasure to solve it as well. In few days (next week) I will probably come up with a proper solution. |
make failures with 1.1.16 on CentOS release 6.5 (Final):
CXXLD benchmark/libbenchmark.la
CXX libgearman-server/plugins/queue/redis/libgearman_server_libgearman_server_la-queue.lo
CXX libgearman-server/plugins/queue/mysql/libgearman_server_libgearman_server_la-queue.lo
CXX libgearman/libgearman_server_libgearman_server_la-backtrace.lo
CXX libgearman/libgearman_server_libgearman_server_la-pipe.lo
libgearman-server/plugins/queue/redis/queue.cc: In member function ‘bool gearmand::plugins::queue::Hiredis::hmset(vchar_t, const void*, size_t, uint32_t)’:
libgearman-server/plugins/queue/redis/queue.cc:97:3: error: variable-sized object ‘argvlen’ may not be initialized
};
^
make[2]: *** [libgearman-server/plugins/queue/redis/libgearman_server_libgearman_server_la-queue.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
/root/gearmand-1.1.16' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/root/gearmand-1.1.16'make: *** [all] Error 2
The text was updated successfully, but these errors were encountered: