Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for interconnect #51

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

thomasdorch
Copy link
Contributor

A few changes to be compatible with my latest changes to the Interconnect plugin.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 21, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.87%.

Quality metrics Before After Change
Complexity 1.01 ⭐ 1.02 ⭐ 0.01 👎
Method Length 114.18 🙂 115.73 🙂 1.55 👎
Working memory 9.01 🙂 9.83 🙂 0.82 👎
Quality 63.85% 🙂 61.98% 🙂 -1.87% 👎
Other metrics Before After Change
Lines 555 559 4
Changed files Quality Before Quality After Quality Change
ubcpdk/init.py 58.15% 🙂 56.53% 🙂 -1.62% 👎
ubcpdk/config.py 59.70% 🙂 56.92% 🙂 -2.78% 👎
ubcpdk/tech.py 63.72% 🙂 63.84% 🙂 0.12% 👍
ubcpdk/components/cells.py 63.65% 🙂 61.10% 🙂 -2.55% 👎
ubcpdk/components/grating_couplers.py 83.12% ⭐ 79.73% ⭐ -3.39% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/components/cells.py ebeam_dc_halfring_straight 1 ⭐ 134 😞 15 😞 55.82% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joamatab joamatab merged commit 8dde87e into gdsfactory:master Jun 21, 2022
@thomasdorch thomasdorch deleted the update_for_interconnect branch June 22, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants