Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix drc errors #186

Merged
merged 12 commits into from
Feb 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## [1.18.0](https://github.com/gdsfactory/ubc/pull/186)

- update to gdsfactory 6.37.0
- fix drc errors

## [1.18.0](https://github.com/gdsfactory/ubc/pull/158)

- update to gdsfactory 6.35.1
- use bbox_layers

## [1.15.0](https://github.com/gdsfactory/ubc/pull/158)

- update to gdsfactory 6.21.1
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ If you don't have python installed on your system you can [download the gdsfacto

### Installation for new gdsfactory users

Open Anaconda Prompt and then install the ubcpdk using pip
If you already have python installed. Open Anaconda Prompt and then install the ubcpdk using pip.

![anaconda prompt](https://i.imgur.com/Fyal5sT.png)

Expand Down
32 changes: 23 additions & 9 deletions docs/components.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,19 @@ Components
:toctree: _autosummary/

add_fiber_array
add_fiber_array_pads_rf
add_pads
add_pads_dc
add_pads_rf
add_pins_bbox_siepic
add_pins_bbox_siepic_remove_layers
add_pins_siepic_metal
bend
bend_euler
bend_s
coupler
coupler_ring
dbg
dbr
dbr_cavity
dbr_cavity_te
Expand All @@ -27,15 +34,9 @@ Components
ebeam_bdc_te1550
ebeam_bdc_tm1550
ebeam_crossing4
ebeam_crossing4_2ports
ebeam_dc_halfring_straight
ebeam_dc_te1550
ebeam_gc_te1310
ebeam_gc_te1310_8deg
ebeam_gc_te1310_broadband
ebeam_gc_te1550
ebeam_gc_te1550_90nmSlab
ebeam_gc_te1550_broadband
ebeam_gc_tm1550
ebeam_splitter_adiabatic_swg_te1550
ebeam_splitter_swg_assist_te1310
ebeam_splitter_swg_assist_te1550
Expand All @@ -46,9 +47,19 @@ Components
ebeam_y_1550
ebeam_y_adiabatic
ebeam_y_adiabatic_1310
ebeam_y_adiabatic_tapers
gc_te1310
gc_te1310_8deg
gc_te1310_broadband
gc_te1550
gc_te1550_90nmSlab
gc_te1550_broadband
gc_tm1550
metal_via
mmi1x2
mzi
mzi_phase_shifter
mzi_heater
pad_array
photonic_wirebond_surfacetaper_1310
photonic_wirebond_surfacetaper_1550
ring_double_heater
Expand All @@ -57,8 +68,11 @@ Components
ring_with_crossing
spiral
straight
straight_one_pin
taper
terminator_short
thermal_phase_shifter0
thermal_phase_shifter1
thermal_phase_shifter2
thermal_phase_shifter3
via_stack
via_stack_heater_mtop
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ authors = [
keywords = ["python"]
license = {file = "LICENSE"}
dependencies = [
"gdsfactory==6.35.0",
"gdsfactory==6.37.0",
"modes",
"klayout",
]
Expand Down
Binary file modified tests/test_components.gds/gds_ref/add_fiber_array_pads_rf.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/bend_euler.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/bend_euler_npoints100.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/bezier_7020f7b9_bend_s.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/coupler.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/coupler_ring.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/dbg.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/ebeam_dc_halfring_straight.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/mzi_55c1098f.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/mzi_ab5edfa6.gds
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/ring_single.gds
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_components.gds/gds_ref/spiral_external_io.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added tests/test_components.gds/gds_ref/taper.gds
Binary file not shown.
Binary file not shown.
4 changes: 3 additions & 1 deletion tests/test_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
skip_test = {
"add_siepic_labels",
"add_fiber_array_siepic",
"add_pins_bbox_siepic",
"add_pins_bbox_siepic_metal",
"add_pins_siepic",
"add_pins_siepic_metal",
"dbr",
"add_pins_bbox_siepic",
"add_pads",
"add_pins_bbox_siepic_remove_layers",
}
cell_names = set(cells.keys()) - set(skip_test)
dirpath = pathlib.Path(__file__).absolute().with_suffix(".gds")
Expand Down
15 changes: 10 additions & 5 deletions tests/test_components/test_pdk_settings_add_fiber_array_.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: straight_add_fiber_arra_98f507a5
name: straight_add_fiber_arra_95f3313e
settings:
changed: {}
child:
Expand All @@ -8,6 +8,10 @@ settings:
settings:
cross_section: strip
fanout_length: 0.0
get_input_label_text_function:
function: get_input_label_text
get_input_labels_function:
function: get_input_labels
grating_coupler:
function: gc_te1550
layer_label:
Expand Down Expand Up @@ -43,8 +47,7 @@ settings:
cross_section: strip
gc_port_labels: null
gc_port_name: o1
get_input_labels_function:
function: get_input_labels
get_input_labels_function: null
grating_coupler:
function: grating_coupler_elliptical_trenches
settings:
Expand All @@ -65,6 +68,8 @@ settings:
fanout_length: 0.0
gc_port_labels: null
gc_port_name: o1
get_input_label_text_function:
function: get_input_label_text
get_input_labels_function:
function: get_input_labels
grating_coupler:
Expand All @@ -90,7 +95,7 @@ settings:
width: 0.5
info_version: 2
module: gdsfactory.routing.add_fiber_array
name: straight_add_fiber_arra_c6cacdf5
name: straight_add_fiber_arra_07129a95
default:
component:
function: straight
Expand Down Expand Up @@ -139,4 +144,4 @@ settings:
width: 0.5
info_version: 2
module: ubcpdk.components
name: straight_add_fiber_arra_98f507a5
name: straight_add_fiber_arra_95f3313e
29 changes: 25 additions & 4 deletions tests/test_components/test_pdk_settings_coupler_.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
name: coupler
name: coupler_50c22d89
settings:
changed: {}
changed:
cross_section:
function: cross_section
settings:
add_bbox:
function: add_bbox_siepic
add_pins:
function: add_pins_siepic
cladding_layers:
- DEVREC
cladding_offsets:
- 0
child: null
default:
coupler_straight:
Expand All @@ -17,7 +28,17 @@ settings:
function: coupler_straight
coupler_symmetric:
function: coupler_symmetric
cross_section: strip
cross_section:
function: cross_section
settings:
add_bbox:
function: add_bbox_siepic
add_pins:
function: add_pins_siepic
cladding_layers:
- DEVREC
cladding_offsets:
- 0
dx: 10.0
dy: 5.0
gap: 0.236
Expand All @@ -28,4 +49,4 @@ settings:
min_bend_radius: 9.451
info_version: 2
module: gdsfactory.components.coupler
name: coupler
name: coupler_50c22d89
15 changes: 10 additions & 5 deletions tests/test_components/test_pdk_settings_dbr_cavity_te_.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: dbr_cavity_add_fiber_ar_619758f4
name: dbr_cavity_add_fiber_ar_a9c9f0b6
settings:
changed:
component:
Expand All @@ -10,6 +10,10 @@ settings:
component: dbr_cavity
settings: {}
fanout_length: 0.0
get_input_label_text_function:
function: get_input_label_text
get_input_labels_function:
function: get_input_labels
grating_coupler:
function: gc_te1550
layer_label:
Expand All @@ -34,8 +38,7 @@ settings:
cross_section: strip
gc_port_labels: null
gc_port_name: o1
get_input_labels_function:
function: get_input_labels
get_input_labels_function: null
grating_coupler:
function: grating_coupler_elliptical_trenches
settings:
Expand All @@ -55,6 +58,8 @@ settings:
fanout_length: 0.0
gc_port_labels: null
gc_port_name: o1
get_input_label_text_function:
function: get_input_label_text
get_input_labels_function:
function: get_input_labels
grating_coupler:
Expand All @@ -77,7 +82,7 @@ settings:
wavelength: 1.55
info_version: 2
module: gdsfactory.routing.add_fiber_array
name: dbr_cavity_add_fiber_ar_c2d56e90
name: dbr_cavity_add_fiber_ar_d14c8fd0
default:
component:
function: straight
Expand Down Expand Up @@ -122,4 +127,4 @@ settings:
wavelength: 1.55
info_version: 2
module: ubcpdk.components
name: dbr_cavity_add_fiber_ar_619758f4
name: dbr_cavity_add_fiber_ar_a9c9f0b6
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: ebeam_crossing4_2ports
settings:
changed: {}
child: null
default: {}
full: {}
function_name: ebeam_crossing4_2ports
info: {}
info_version: 2
module: ubcpdk.components
name: ebeam_crossing4_2ports
14 changes: 11 additions & 3 deletions tests/test_components/test_pdk_settings_ebeam_dc_te1550_.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: coupler
name: coupler_d51b16db
settings:
changed: {}
changed:
decorator:
function: add_pins_bbox_siepic
settings:
remove_layers: true
child: null
default:
coupler_straight:
Expand All @@ -18,6 +22,10 @@ settings:
coupler_symmetric:
function: coupler_symmetric
cross_section: strip
decorator:
function: add_pins_bbox_siepic
settings:
remove_layers: true
dx: 10.0
dy: 5.0
gap: 0.236
Expand All @@ -28,4 +36,4 @@ settings:
min_bend_radius: 9.451
info_version: 2
module: gdsfactory.components.coupler
name: coupler
name: coupler_d51b16db
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: ebeam_y_adiabatic_tapers
settings:
changed: {}
child: null
default: {}
full: {}
function_name: ebeam_y_adiabatic_tapers
info:
library: Design kits/ebeam
model: ebeam_y_adiabatic
info_version: 2
module: ubcpdk.components
name: ebeam_y_adiabatic_tapers
52 changes: 52 additions & 0 deletions tests/test_components/test_pdk_settings_mmi1x2_.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: mmi1x2_50c22d89
settings:
changed:
cross_section:
function: cross_section
settings:
add_bbox:
function: add_bbox_siepic
add_pins:
function: add_pins_siepic
cladding_layers:
- DEVREC
cladding_offsets:
- 0
child: null
default:
cross_section: strip
gap_mmi: 0.25
length_mmi: 5.5
length_taper: 10.0
taper:
function: taper
width: null
width_mmi: 2.5
width_taper: 1.0
with_bbox: true
full:
cross_section:
function: cross_section
settings:
add_bbox:
function: add_bbox_siepic
add_pins:
function: add_pins_siepic
cladding_layers:
- DEVREC
cladding_offsets:
- 0
gap_mmi: 0.25
length_mmi: 5.5
length_taper: 10.0
taper:
function: taper
width: null
width_mmi: 2.5
width_taper: 1.0
with_bbox: true
function_name: mmi1x2
info: {}
info_version: 2
module: gdsfactory.components.mmi1x2
name: mmi1x2_50c22d89
Loading