Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow gdsfactory port naming convention #158

Merged
merged 5 commits into from
Jan 15, 2023
Merged

follow gdsfactory port naming convention #158

merged 5 commits into from
Jan 15, 2023

Conversation

joamatab
Copy link
Contributor

  • update to gdsfactory 6.21.1
  • use o1, o2, o3 port naming convention instead of opt1, opt2, opt3

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 15, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 9.66%.

Quality metrics Before After Change
Complexity 2.13 ⭐ 4.66 ⭐ 2.53 👎
Method Length 30.58 ⭐ 40.83 ⭐ 10.25 👎
Working memory 5.46 ⭐ 7.34 🙂 1.88 👎
Quality 85.67% 76.01% -9.66% 👎
Other metrics Before After Change
Lines 585 738 153
Changed files Quality Before Quality After Quality Change
ubcpdk/components.py 90.12% ⭐ 90.18% ⭐ 0.06% 👍
ubcpdk/import_gds.py 77.41% ⭐ 57.98% 🙂 -19.43% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/import_gds.py add_ports_from_siepic_pins 18 🙂 282 ⛔ 18 ⛔ 26.57% 😞 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py ebeam_dc_halfring_straight 1 ⭐ 147 😞 15 😞 54.37% 🙂 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py dbr 0 ⭐ 60 ⭐ 14 😞 68.29% 🙂 Extract out complex expressions
ubcpdk/components.py add_fiber_array 0 ⭐ 44 ⭐ 10 😞 77.45% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #158 (f3ecc12) into main (1b44bdd) will increase coverage by 4.06%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   58.72%   62.79%   +4.06%     
==========================================
  Files          17       17              
  Lines         487      551      +64     
==========================================
+ Hits          286      346      +60     
- Misses        201      205       +4     
Impacted Files Coverage Δ
ubcpdk/import_gds.py 59.59% <87.75%> (+25.66%) ⬆️
ubcpdk/components.py 97.94% <96.42%> (-0.46%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

follow gdsfactory port naming convention  (Sourcery refactored)
@joamatab joamatab merged commit e2f75e0 into main Jan 15, 2023
@joamatab joamatab deleted the 1141 branch January 15, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant