Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text color gets changed when clicking on the same dropdown twice. #1406

Closed
nightowl286 opened this issue Sep 2, 2022 · 4 comments
Closed
Labels

Comments

@nightowl286
Copy link

Describe the bug
The text color gets changed to a barely readable one when you click on the same dropdown twice.

To Reproduce

  1. Go to settings.
  2. Change theme to dark.
  3. Expand any dropdown twice.

Expected behaviour
Readable text

Screenshots
image

Desktop (if relevant, please complete the following information):

  • OS: Windows
  • Browser: firefox 104.0.1
  • CyberChef version: 9.46.0

Additional context
None

@nightowl286 nightowl286 added the bug label Sep 2, 2022
@nightowl286 nightowl286 changed the title Bug report: <Insert title here> Text color gets changed when click on dropdown twice. Sep 2, 2022
@nightowl286 nightowl286 changed the title Text color gets changed when click on dropdown twice. Text color gets changed when clicking on the same dropdown twice. Sep 2, 2022
@bolshoytoster
Copy link

@nightowl286 testing this, I've found that what you describe:

when you click on the same dropdown twice.

is only true for firefox on windows, I found that on chromium the dropdown text is always like that (probably related) and I've only been able to reproduce this on linux with chromium (dropdowns typically use the system theme).


Looking further into it, the "barely readable" colour is intentional - it's the primary font colour for the dark theme (we could probably change the background to make it more readable).

This means that chromium handles this correctly, but firefox doesn't.


After a bit of testing, I found that for some reason, there's a color: rgb(73, 80, 87) (from bootstrap) that sometimes wins over the theme colour on firefox. We can simply add a !important to the theme colour to override it and everything works properly.

And the readability issue can be solved by enforcing the background colour for the dropdowns in the same way.

@n1474335
Copy link
Member

n1474335 commented Sep 9, 2022

I believe this should be fixed by #1407 which has now been merged. Please reopen if the problem persists.

@n1474335 n1474335 closed this as completed Sep 9, 2022
@nightowl286
Copy link
Author

Seem to be getting a slightly different (but likely related) problem now, now the color isn't correct on the first opening of the dropdown.

Still the same OS.
Firefox version: 104.0.2
Cyberchef version: 9.46.2

Attached a clip since the 2nd dropdown has a slightly different behaviour that was difficult to describe.

cyberchef.webm

@bolshoytoster
Copy link

@nightowl286 the colour you see first is the intended colour for the dark theme, it could probably be changed. My PR doesn't cause the colour to change on the second opening like the merged one does, so I'd like to reopen my PR instead and also change the dark mode primary colour to make this more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants