-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text color gets changed when clicking on the same dropdown twice. #1406
Comments
@nightowl286 testing this, I've found that what you describe:
is only true for firefox on windows, I found that on chromium the dropdown text is always like that (probably related) and I've only been able to reproduce this on linux with chromium (dropdowns typically use the system theme). Looking further into it, the "barely readable" colour is intentional - it's the primary font colour for the dark theme (we could probably change the background to make it more readable). This means that chromium handles this correctly, but firefox doesn't. After a bit of testing, I found that for some reason, there's a And the readability issue can be solved by enforcing the background colour for the dropdowns in the same way. |
I believe this should be fixed by #1407 which has now been merged. Please reopen if the problem persists. |
Seem to be getting a slightly different (but likely related) problem now, now the color isn't correct on the first opening of the dropdown. Still the same OS. Attached a clip since the 2nd dropdown has a slightly different behaviour that was difficult to describe. cyberchef.webm |
@nightowl286 the colour you see first is the intended colour for the dark theme, it could probably be changed. My PR doesn't cause the colour to change on the second opening like the merged one does, so I'd like to reopen my PR instead and also change the dark mode primary colour to make this more readable. |
Describe the bug
The text color gets changed to a barely readable one when you click on the same dropdown twice.
To Reproduce
Expected behaviour
Readable text
Screenshots

Desktop (if relevant, please complete the following information):
Additional context
None
The text was updated successfully, but these errors were encountered: