Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Possible misnaming of XOR Output Differential and perhaps input differential (9.7.9) #1155

Closed
l3fdb33f opened this issue Jan 4, 2021 · 1 comment

Comments

@l3fdb33f
Copy link

l3fdb33f commented Jan 4, 2021

Hi, I was working to re-implement a CyberChef recipe in python as I am decrypting some strings; part of the encryption fell away as I used the XOR output differential recipe option (I'm on 9.7.9 so this may be fixed) however,

When I implemented output differential in python, the decryption didn't work. After some testing, the CyberChef operation actually appears to be doing XOR input differential. The following screenshot should elaborate. If it were output differential, the 5th byte in the output, 0xe9, should be 0xf2^0xc7, which would be 0x35. Instead, it's 0xf2^0x1b. This shows the key is the previous unprocessed byte, AKA input differential.
xor

@n1474335
Copy link
Member

n1474335 commented Sep 3, 2021

You're absolutely right. I had the input and output differential logic swapped. This has now been fixed in v9.32.3. Thanks for spotting and raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants