Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systems can create entities and components during update #6

Open
osrf-migration opened this issue Oct 18, 2018 · 3 comments
Open

Systems can create entities and components during update #6

osrf-migration opened this issue Oct 18, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


A System has the ability to create new entities and components during the System update phase. This behavior is inconsistent with entity and component removal, which happens after the System update phase.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set component to "GoodForNewcomers"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • removed "GoodForNewcomers" component

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


The RequestRemoveEntity mechanism is currently protecting entity removal. We may want to extend that logic to entity creation, as well as component creation / removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants